Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 990653002: Add device_unittests target to linux_default_tests list. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, brettw, scottmg_chrommium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add device_unittests target to linux_default_tests list. This is a target I converted to GN and it is known to run fine. Tested on Linux with the following command lines: $ gn gen out-gn $ ninja -C out-gn device_unittests $ out-gn/device_unittests BUG=None TEST=see above R=dpranke@chromium.org TBR=brettw@chromium.org Committed: https://crrev.com/466754fafc5e55e02090e56365d4cc3f8ecc01ea Cr-Commit-Position: refs/heads/master@{#319772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
PTAL!
5 years, 9 months ago (2015-03-07 22:44:24 UTC) #1
tfarina
Ping?
5 years, 9 months ago (2015-03-09 21:39:47 UTC) #2
Dirk Pranke
lgtm. Sorry, I must've missed this somehow ...
5 years, 9 months ago (2015-03-09 22:35:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990653002/1
5 years, 9 months ago (2015-03-09 22:57:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 23:39:37 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 23:40:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/466754fafc5e55e02090e56365d4cc3f8ecc01ea
Cr-Commit-Position: refs/heads/master@{#319772}

Powered by Google App Engine
This is Rietveld 408576698