Device enumeration on Android now thread safe

Device enumeration on Android now thread safe.

see https://codereview.chromium.org/78033003/ for the original CL...

BUG=324464
TEST=https://simpl.info/getusermedia/sources/ and manual unittests in media.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238509

[wjia(left Chromium), 2013-12-02 22:57:26]

https://codereview.chromium.org/99063002/diff/1/media/base/android/java/src/o...
File media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java
(right):

https://codereview.chromium.org/99063002/diff/1/media/base/android/java/src/o...
media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java:225: if
(mAudioDevices[DEVICE_BLUETOOTH_HEADSET]) {
The lock is needed here, right? And several other places?

https://codereview.chromium.org/99063002/diff/1/media/base/android/java/src/o...
media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java:255:
synchronized (mLock) {
Could you just use synchronized(this)?

[henrika (OOO until Aug 14), 2013-12-03 12:31:01]

Thanks Wei. Think we should be safe now.

https://codereview.chromium.org/99063002/diff/1/media/base/android/java/src/o...
File media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java
(right):

https://codereview.chromium.org/99063002/diff/1/media/base/android/java/src/o...
media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java:225: if
(mAudioDevices[DEVICE_BLUETOOTH_HEADSET]) {
On 2013/12/02 22:57:26, wjia wrote:
> The lock is needed here, right? And several other places?

Done.

https://codereview.chromium.org/99063002/diff/1/media/base/android/java/src/o...
media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java:255:
synchronized (mLock) {
It does not seem to be the preferred way in Chrome and I actually think it
should be avoided (see e.g.
http://stackoverflow.com/questions/442564/avoid-synchronizedthis-in-java).

[henrika (OOO until Aug 14), 2013-12-03 12:32:10]

Thanks Wei. Think we should be safe now.

PTAL.

[wjia(left Chromium), 2013-12-03 17:25:16]

lgtm with one comment.

adding qinmin@ for owner stamp.

https://codereview.chromium.org/99063002/diff/40001/media/base/android/java/s...
File media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java
(right):

https://codereview.chromium.org/99063002/diff/40001/media/base/android/java/s...
media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java:536:
private int getNumOfAudioDevices() {
It would be better to rename this to getNumOfAudioDevicesWithLock since it's
called with lock acquired.

[qinmin, 2013-12-03 17:33:18]

lgtm

[henrika (OOO until Aug 14), 2013-12-03 17:56:20]

Thanks for the fast review response.

https://codereview.chromium.org/99063002/diff/40001/media/base/android/java/s...
File media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java
(right):

https://codereview.chromium.org/99063002/diff/40001/media/base/android/java/s...
media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java:536:
private int getNumOfAudioDevices() {
Good point. Will do.

[commit-bot: I haz the power, 2013-12-03 17:58:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/henrika@chromium.org/99063002/60001

[commit-bot: I haz the power, 2013-12-03 19:18:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/henrika@chromium.org/99063002/60001

[commit-bot: I haz the power, 2013-12-03 23:48:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/henrika@chromium.org/99063002/60001

[commit-bot: I haz the power, 2013-12-04 00:57:22]

Change committed as 238509