Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 990613002: Sync the HTMLCollection interfaces with the specs (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, vivekg, dglazkov+blink, Inactive
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the HTMLCollection interfaces with the specs https://dom.spec.whatwg.org/#interface-htmlcollection https://html.spec.whatwg.org/#the-htmlallcollection-interface https://html.spec.whatwg.org/#the-htmlformcontrolscollection-interface https://html.spec.whatwg.org/#the-htmloptionscollection-interface There are no changes to the generated code other than the order. The console-format-collections.html test expectations depended on a specific order and were updated. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191492

Patch Set 1 #

Patch Set 2 : update order-dependent test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M LayoutTests/inspector/console/console-format-collections-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAllCollection.idl View 2 chunks +9 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCollection.idl View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.idl View 1 chunk +6 lines, -1 line 0 comments Download
M Source/core/html/HTMLOptionsCollection.idl View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
philipj_slow
PTAL. These interfaces are a quite the mess of not-quite-per-spec IDL and custom code, so ...
5 years, 9 months ago (2015-03-07 18:05:34 UTC) #2
Jens Widell
LGTM
5 years, 9 months ago (2015-03-07 18:11:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990613002/1
5 years, 9 months ago (2015-03-07 18:29:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-07 21:29:05 UTC) #7
philipj_slow
update order-dependent test expectations
5 years, 9 months ago (2015-03-08 08:59:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990613002/20001
5 years, 9 months ago (2015-03-08 08:59:45 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-08 22:34:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191492

Powered by Google App Engine
This is Rietveld 408576698