Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h - Issue 990583002: Use UUID for ServiceWorker Client identifier (1/3, blink)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 990583002: Use UUID for ServiceWorker Client identifier (1/3, blink) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerClient.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

index ddff85e814fbb5705f3f2fd24a83b6639eb3620e..0aa75db178c55e372c4c7b3eaf2c41f461c547f8 100644

--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

@@ -76,11 +76,13 @@ public:

virtual void didHandlePushEvent(int pushEventID, WebServiceWorkerEventResult) = 0;

virtual void didHandleSyncEvent(int syncEventID) = 0;

virtual void didHandleCrossOriginConnectEvent(int connectEventID, bool acceptConnect) = 0;

- virtual void postMessageToClient(int clientID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) = 0;

+ virtual void postMessageToClient(int clientID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) = 0; // FIXME: Deprecate this once we switch to uuid.

+ virtual void postMessageToClient(const WebString& clientUUID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) = 0;

virtual void postMessageToCrossOriginClient(const WebCrossOriginServiceWorkerClient&, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) = 0;

virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) = 0;

virtual void claim(WebServiceWorkerClientsClaimCallbacks*) = 0;

- virtual void focus(int clientID, WebServiceWorkerClientCallbacks*) = 0;

+ virtual void focus(int clientID, WebServiceWorkerClientCallbacks*) = 0; // FIXME: Deprecate this once we switch to uuid.

+ virtual void focus(const WebString& clientUUID, WebServiceWorkerClientCallbacks*) = 0;

static const char* supplementName();

static ServiceWorkerGlobalScopeClient* from(ExecutionContext*);