Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 990583002: Use UUID for ServiceWorker Client identifier (1/3, blink) (Closed)

Created:
5 years, 9 months ago by kinuko
Modified:
5 years, 9 months ago
Reviewers:
falken, tkent
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use UUID for ServiceWorker Client identifier (1/3, blink) I'm not going to surface the new 'id' field on Client surface yet, but here're the spec pointers that explains why we do this: Spec issue: https://github.com/slightlyoff/ServiceWorker/issues/634 More context: https://github.com/slightlyoff/ServiceWorker/issues/609 To be landed in 3 patches: 1/3: THIS 2/3: chromium-side patch https://crrev.com/988063004/ 3/3: blink-side cleanup BUG=464668 TEST=existing tests should pass Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191591

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -13 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerClient.h View 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClient.cpp View 1 2 chunks +7 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M public/platform/WebServiceWorkerClientsInfo.h View 1 chunk +2 lines, -1 line 0 comments Download
M public/web/WebServiceWorkerContextClient.h View 1 2 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kinuko
PTL (no changes in API surface yet)
5 years, 9 months ago (2015-03-09 01:57:49 UTC) #3
falken
lgtm
5 years, 9 months ago (2015-03-09 03:39:35 UTC) #4
kinuko
Kent-san, could you review Source/web and public/ changes?
5 years, 9 months ago (2015-03-09 09:33:07 UTC) #6
tkent
lgtm
5 years, 9 months ago (2015-03-10 00:20:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990583002/60001
5 years, 9 months ago (2015-03-10 00:21:14 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 00:26:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191591

Powered by Google App Engine
This is Rietveld 408576698