Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 990553003: Set product_name on many targets to use a crashpad_ prefix (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek, scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Set target_name on many targets to use a crashpad_ prefix. In Chromium, many targets are built, sharing a single output directory. Collisions are likely. When integrating Crashpad into Chromium, the ui/snapshot library and Crashpad’s snapshot library were found to conflict. This change gives most Crashpad targets a “crashpad_” prefix to avoid conflicts. All library and test targets are given a target_name with this prefix. Existing tools are not likely to conflict with anything else and are not given a prefix. BUG=crashpad:12 R=rsesek@chromium.org, scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b256df05344dd0593079d72ad0174f218c4592f8

Patch Set 1 #

Patch Set 2 : Windows #

Patch Set 3 : Use target_name instead of product_name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -75 lines) Patch
M build/run_tests.py View 1 chunk +4 lines, -4 lines 0 comments Download
M client/client.gyp View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M compat/compat.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M handler/handler.gyp View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M minidump/minidump.gyp View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M snapshot/snapshot.gyp View 1 2 3 chunks +14 lines, -14 lines 0 comments Download
M tools/tools.gyp View 1 2 6 chunks +18 lines, -18 lines 0 comments Download
M util/test/executable_path_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M util/util.gyp View 1 2 5 chunks +12 lines, -12 lines 0 comments Download
M util/win/process_info_test.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-07 19:21:53 UTC) #1
Mark Mentovai
5 years, 9 months ago (2015-03-07 19:22:59 UTC) #3
Mark Mentovai
5 years, 9 months ago (2015-03-07 19:32:26 UTC) #5
scottmg
I might have just changed the target_names? But lgtm.
5 years, 9 months ago (2015-03-07 21:33:03 UTC) #6
Mark Mentovai
If you guys would prefer that, I can do it that way. The real reason ...
5 years, 9 months ago (2015-03-07 21:51:14 UTC) #7
Robert Sesek
I don't have a philosophical opinion on whether the target_name should match product_name, and I ...
5 years, 9 months ago (2015-03-08 03:41:34 UTC) #8
Mark Mentovai
ninja responds to both names: mark@mela zsh% ninja -C out/Debug client_test ninja: Entering directory `out/Debug' ...
5 years, 9 months ago (2015-03-08 15:22:05 UTC) #9
Robert Sesek
Yeah, I thought ninja allowed both, but I do think the consistency is better. LGTM
5 years, 9 months ago (2015-03-08 19:58:12 UTC) #10
Mark Mentovai
5 years, 9 months ago (2015-03-08 20:25:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b256df05344dd0593079d72ad0174f218c4592f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698