Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: chrome/android/java/res/layout/autofill_card_unmask_prompt.xml

Issue 990543002: Android Autofill card unmasking prompt - Add tooltip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: viewcompat 2 Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/autofill_card_unmask_prompt.xml
diff --git a/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml b/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml
index a0091b624883392b18163597b8b197844c41252a..8840207fab2c91d98d326e2058ff4640516de0b6 100644
--- a/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml
+++ b/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml
@@ -116,17 +116,38 @@
android:textColor="@color/input_underline_error_color"
android:visibility="gone" />
- <CheckBox
- android:id="@+id/store_locally_checkbox"
+ <RelativeLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:layout_marginStart="17dp"
- android:layout_marginEnd="10dp"
- android:layout_marginTop="16dp"
- android:paddingStart="7dp"
- android:textSize="14sp"
- android:textColor="@color/explanation_text_color"
- android:text="@string/autofill_card_unmask_prompt_storage_checkbox" />
+ android:layout_marginTop="16dp">
+
+ <!-- TODO(estade): Content description? -->
+ <ImageView
+ android:id="@+id/store_locally_tooltip_icon"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_marginEnd="12dp"
+ android:layout_alignParentEnd="true"
+ android:layout_centerVertical="true"
+ android:padding="12dp"
+ android:src="@drawable/help_outline"
+ android:contentDescription="@null" />
+
+ <CheckBox
+ android:id="@+id/store_locally_checkbox"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_alignParentStart="true"
+ android:layout_toStartOf="@id/store_locally_tooltip_icon"
+ android:layout_centerVertical="true"
+ android:layout_marginStart="17dp"
+ android:layout_marginEnd="10dp"
+ android:paddingStart="7dp"
+ android:textSize="14sp"
+ android:textColor="@color/explanation_text_color"
+ android:text="@string/autofill_card_unmask_prompt_storage_checkbox" />
+
+ </RelativeLayout>
</LinearLayout>
<LinearLayout
« no previous file with comments | « chrome/android/java/res/drawable/store_locally_tooltip_background.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698