Android Autofill card unmasking prompt - Add tooltip

chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.autofill;
 
 import android.app.AlertDialog;
 import android.content.Context;
 import android.content.DialogInterface;
+import android.content.res.Resources;
+import android.graphics.Color;
 import android.graphics.ColorFilter;
 import android.graphics.PorterDuff;
 import android.graphics.PorterDuffColorFilter;
 import android.os.Build;
 import android.os.Handler;
 import android.support.v4.view.ViewCompat;
 import android.text.Editable;
 import android.text.TextWatcher;
 import android.view.LayoutInflater;
 import android.view.View;
+import android.view.View.OnLongClickListener;
 import android.view.ViewGroup;
+import android.view.ViewGroup.LayoutParams;
 import android.view.inputmethod.InputMethodManager;
 import android.widget.Button;
 import android.widget.CheckBox;
 import android.widget.EditText;
 import android.widget.ImageView;
+import android.widget.PopupWindow;
 import android.widget.ProgressBar;
+import android.widget.RelativeLayout;
 import android.widget.TextView;
 
 import org.chromium.chrome.R;
 
 import java.util.Calendar;
 
 /**
  * A prompt that bugs users to enter their CVC when unmasking a Wallet instrument (credit card).
  */
-public class CardUnmaskPrompt implements DialogInterface.OnDismissListener, TextWatcher {
+public class CardUnmaskPrompt
+        implements DialogInterface.OnDismissListener, TextWatcher, OnLongClickListener {
     private final CardUnmaskPromptDelegate mDelegate;
     private final AlertDialog mDialog;
     private final boolean mShouldRequestExpirationDate;
     private final int mThisYear;
 
+    private final View mMainView;
     private final TextView mNoRetryErrorMessage;
     private final EditText mCardUnmaskInput;
     private final EditText mMonthInput;
     private final EditText mYearInput;
     private final View mExpirationContainer;
     private final TextView mErrorMessage;
     private final CheckBox mStoreLocallyCheckbox;
+    private final ImageView mStoreLocallyTooltipIcon;
+    private PopupWindow mStoreLocallyTooltipPopup;
     private final ViewGroup mMainContents;
     private final View mVerificationOverlay;
     private final ProgressBar mVerificationProgressBar;
     private final TextView mVerificationView;
 
     /**
      * An interface to handle the interaction with an CardUnmaskPrompt object.
      */
     public interface CardUnmaskPromptDelegate {
         /**
@@ skipping 19 matching lines @@
 
     public CardUnmaskPrompt(Context context, CardUnmaskPromptDelegate delegate, String title,
             String instructions, int drawableId, boolean shouldRequestExpirationDate,
             boolean defaultToStoringLocally) {
         mDelegate = delegate;
 
         LayoutInflater inflater = LayoutInflater.from(context);
         View v = inflater.inflate(R.layout.autofill_card_unmask_prompt, null);
         ((TextView) v.findViewById(R.id.instructions)).setText(instructions);
 
+        mMainView = v;
         mNoRetryErrorMessage = (TextView) v.findViewById(R.id.no_retry_error_message);
         mCardUnmaskInput = (EditText) v.findViewById(R.id.card_unmask_input);
         mMonthInput = (EditText) v.findViewById(R.id.expiration_month);
         mYearInput = (EditText) v.findViewById(R.id.expiration_year);
         mExpirationContainer = v.findViewById(R.id.expiration_container);
         mErrorMessage = (TextView) v.findViewById(R.id.error_message);
         mStoreLocallyCheckbox = (CheckBox) v.findViewById(R.id.store_locally_checkbox);
         mStoreLocallyCheckbox.setChecked(defaultToStoringLocally);
+        mStoreLocallyTooltipIcon = (ImageView) v.findViewById(R.id.store_locally_tooltip_icon);
+        mStoreLocallyTooltipIcon.setOnLongClickListener(this);
         mMainContents = (ViewGroup) v.findViewById(R.id.main_contents);
         mVerificationOverlay = v.findViewById(R.id.verification_overlay);
         mVerificationProgressBar = (ProgressBar) v.findViewById(R.id.verification_progress_bar);
         mVerificationView = (TextView) v.findViewById(R.id.verification_message);
         ((ImageView) v.findViewById(R.id.cvc_hint_image)).setImageResource(drawableId);
 
         mDialog = new AlertDialog.Builder(context)
                           .setTitle(title)
                           .setView(v)
                           .setNegativeButton(R.string.cancel, null)
@@ skipping 87 matching lines @@
     public void afterTextChanged(Editable s) {
         mDialog.getButton(AlertDialog.BUTTON_POSITIVE).setEnabled(areInputsValid());
     }
 
     @Override
     public void beforeTextChanged(CharSequence s, int start, int count, int after) {}
 
     @Override
     public void onTextChanged(CharSequence s, int start, int before, int count) {}
 
+    @Override
+    public boolean onLongClick(View v) {
+        assert (v == mStoreLocallyTooltipIcon);

[newt (away), 2015/03/09 18:15:53]

nit: don't need () around assert statement

[Evan Stade, 2015/03/09 18:54:13]

Done.

+        if (mStoreLocallyTooltipPopup == null) {
+            mStoreLocallyTooltipPopup = new PopupWindow(mDialog.getContext());
+            TextView text = new TextView(mDialog.getContext());
+            // TODO(estade): change to AUTOFILL_CARD_UNMASK_PROMPT_STORAGE_TOOLTIP.
+            text.setText(R.string.card_unmask_input_hint);
+            // Width is the dialog's width less the margins and padding around the checkbox and
+            // icon.
+            text.setWidth(mMainView.getWidth() - mStoreLocallyCheckbox.getPaddingStart()

[newt (away), 2015/03/09 18:15:53]

All these *start() and *end() methods were added in API 17. You should use the
methods in ApiCompatibilityUtils.

I'm curious: did this cause Android lint "NewApi" warnings in your local build?
It should have.

[Evan Stade, 2015/03/09 18:54:13]

Done. No lint errors seen (just a bunch of resource-related error messages).

+                    - mStoreLocallyTooltipIcon.getPaddingEnd()
+                    - ((RelativeLayout.LayoutParams) mStoreLocallyCheckbox.getLayoutParams())
+                              .getMarginStart()
+                    - ((RelativeLayout.LayoutParams) mStoreLocallyTooltipIcon.getLayoutParams())
+                              .getMarginEnd());
+            text.setTextColor(Color.WHITE);
+            Resources resources = mDialog.getContext().getResources();
+            int hPadding = resources.getDimensionPixelSize(
+                    R.dimen.autofill_card_unmask_tooltip_horizontal_padding);
+            int vPadding = resources.getDimensionPixelSize(
+                    R.dimen.autofill_card_unmask_tooltip_vertical_padding);
+            text.setPadding(hPadding, vPadding, hPadding, vPadding);
+
+            mStoreLocallyTooltipPopup.setContentView(text);
+            mStoreLocallyTooltipPopup.setWindowLayoutMode(
+                    LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT);
+            mStoreLocallyTooltipPopup.setOutsideTouchable(true);
+            mStoreLocallyTooltipPopup.setBackgroundDrawable(
+                    resources.getDrawable(R.drawable.store_locally_tooltip_background));
+        }
+        mStoreLocallyTooltipPopup.showAsDropDown(mStoreLocallyCheckbox,
+                mStoreLocallyCheckbox.getPaddingStart(), 0);
+        return true;
+    }
+
     private void setInitialFocus() {
         InputMethodManager imm = (InputMethodManager) mDialog.getContext().getSystemService(
                 Context.INPUT_METHOD_SERVICE);
         imm.showSoftInput(mShouldRequestExpirationDate ? mMonthInput : mCardUnmaskInput,
                 InputMethodManager.SHOW_IMPLICIT);
     }
 
     private boolean areInputsValid() {
         if (mShouldRequestExpirationDate) {
             try {
@@ skipping 89 matching lines @@
         try {
             int year = Integer.parseInt(mYearInput.getText().toString());
             if (year < 0) return -1;
             if (year < 100) year += mThisYear - mThisYear % 100;
             return year;
         } catch (NumberFormatException e) {
             return -1;
         }
     }
 }