chrome/android/java/res/layout/autofill_card_unmask_prompt.xml - Issue 990543002: Android Autofill card unmasking prompt - Add tooltip

Side by Side Diff: chrome/android/java/res/layout/autofill_card_unmask_prompt.xml

Issue 990543002: Android Autofill card unmasking prompt - Add tooltip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable/store_locally_tooltip_background.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"	8 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

9 android:layout_width="wrap_content"	9 android:layout_width="wrap_content"

10 android:layout_height="wrap_content">	10 android:layout_height="wrap_content">

(...skipping 98 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
109 android:id="@+id/error_message"	109 android:id="@+id/error_message"

110 android:layout_width="match_parent"	110 android:layout_width="match_parent"

111 android:layout_height="wrap_content"	111 android:layout_height="wrap_content"

112 android:layout_marginStart="24dp"	112 android:layout_marginStart="24dp"

113 android:layout_marginEnd="24dp"	113 android:layout_marginEnd="24dp"

114 android:gravity="start"	114 android:gravity="start"

115 android:textSize="12sp"	115 android:textSize="12sp"

116 android:textColor="@color/input_underline_error_color"	116 android:textColor="@color/input_underline_error_color"

117 android:visibility="gone" />	117 android:visibility="gone" />

118	118

119 <CheckBox	119 <RelativeLayout

120 android:id="@+id/store_locally_checkbox"

121 android:layout_width="match_parent"	120 android:layout_width="match_parent"

122 android:layout_height="wrap_content"	121 android:layout_height="wrap_content"

123 android:layout_marginStart="17dp"	122 android:layout_marginTop="16dp">

124 android:layout_marginEnd="10dp"	123

125 android:layout_marginTop="16dp"	124 <CheckBox

126 android:paddingStart="7dp"	125 android:id="@+id/store_locally_checkbox"

127 android:textSize="14sp"	126 android:layout_width="wrap_content"

128 android:textColor="@color/explanation_text_color"	127 android:layout_height="wrap_content"

129 android:text="@string/autofill_card_unmask_prompt_store_locally" />	128 android:layout_alignParentStart="true"

	129 android:layout_centerVertical="true"
	newt (away) 2015/03/09 18:20:22 you should specify layout_toStartOf here. Otherwis you should specify layout_toStartOf here. Otherwise, if this text is really long, it'll overlap the tooltip icon. Evan Stade 2015/03/09 18:54:13 Done. Show quoted text On 2015/03/09 18:20:22, newt wrote: > you should specify layout_toStartOf here. Otherwise, if this text is really > long, it'll overlap the tooltip icon. Done.
	130 android:layout_marginStart="17dp"

	131 android:layout_marginEnd="10dp"

	132 android:paddingStart="7dp"

	133 android:textSize="14sp"

	134 android:textColor="@color/explanation_text_color"

	135 android:text="@string/autofill_card_unmask_prompt_store_locally" />

	136

	137 <!-- TODO(estade): get (?) resources in all scales. -->

	138 <!-- TODO(estade): Content description? -->

	139 <ImageView

	140 android:id="@+id/store_locally_tooltip_icon"

	141 android:layout_width="wrap_content"

	142 android:layout_height="wrap_content"

	143 android:layout_marginEnd="12dp"
	newt (away) 2015/03/09 18:20:22 Do you really need marginEnd and paddingEnd? Same Do you really need marginEnd and paddingEnd? Same above. Evan Stade 2015/03/09 18:54:13 my understanding is that margin and padding affect Show quoted text On 2015/03/09 18:20:22, newt wrote: > Do you really need marginEnd and paddingEnd? Same above. my understanding is that margin and padding affect the event hitbox differently, so yes
	144 android:layout_alignParentEnd="true"

	145 android:layout_centerVertical="true"

	146 android:padding="12dp"

	147 android:src="@drawable/deprecation_warning"

	148 android:contentDescription="@null" />

	149

	150 </RelativeLayout>

130 </LinearLayout>	151 </LinearLayout>

131	152

132 <LinearLayout	153 <LinearLayout

133 android:id="@+id/verification_overlay"	154 android:id="@+id/verification_overlay"

134 android:layout_width="wrap_content"	155 android:layout_width="wrap_content"

135 android:layout_height="wrap_content"	156 android:layout_height="wrap_content"

136 android:layout_alignTop="@+id/main_contents"	157 android:layout_alignTop="@+id/main_contents"

137 android:layout_alignBottom="@+id/main_contents"	158 android:layout_alignBottom="@+id/main_contents"

138 android:layout_alignStart="@+id/main_contents"	159 android:layout_alignStart="@+id/main_contents"

139 android:layout_alignEnd="@+id/main_contents"	160 android:layout_alignEnd="@+id/main_contents"

(...skipping 19 matching lines...) Expand all Loading...
159 android:contentDescription="@null" />	180 android:contentDescription="@null" />

160	181

161 <TextView	182 <TextView

162 android:id="@+id/verification_message"	183 android:id="@+id/verification_message"

163 android:layout_width="wrap_content"	184 android:layout_width="wrap_content"

164 android:layout_height="wrap_content"	185 android:layout_height="wrap_content"

165 android:textColor="?attr/colorAccent"	186 android:textColor="?attr/colorAccent"

166 android:textSize="20sp" />	187 android:textSize="20sp" />

167 </LinearLayout>	188 </LinearLayout>

168 </RelativeLayout>	189 </RelativeLayout>

OLD	NEW