Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 990533002: Land Recent QUIC Changes until 03/06/2015. (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes until 03/06/2015. CL generated with data from dead-code analysis using .../scythe:remove_dead_code Dead code removal. Merge internal change: 87991626 https://codereview.chromium.org/987693006/ Add 'explicit' to the PacketWriterFactoryAdapter constructor, as complained about by Lint. Merge internal change: 87956343 https://codereview.chromium.org/988963002/ Adds an assert to confirm that QUIC's session flow control window is always larger than the stream flow control window, and fixes some tests. Merge internal change: 87837841 https://codereview.chromium.org/987943003/ Implement the "sanity checks" described in b/9509040: Incoming packets whose connection ID is not associated with a session and is not recorded as being in time-wait state are tested for reasonableness before a session is created for them. This won't protect much against deliberate DoS but will screen out a reasonable fraction of truly junk packets. Add sanity tests so we do not create connections for initial packets with truncated connection IDs. Merge internal change: 87831756 https://codereview.chromium.org/981193003/ Change the null value for packet sequence numbers to kInvalidPacketSequenceNumber (== 0), which cannot appear as a packet sequence number. Update QuicFecGroupTest::UpdateAndRevive and QuicFecGroupTest::UpdateAndReviveOutOfOrder to generate packet numbers starting with 1 rather than 0. Change the null value for packet sequence numbers to kNullPacketSequenceNumber (== 0). Merge internal change: 87819844 https://codereview.chromium.org/989743003/ R=rch@chromium.org Committed: https://crrev.com/9e0fb50a74c11981a86c18ad507ece44735b3b98 Cr-Commit-Position: refs/heads/master@{#319581}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -267 lines) Patch
M net/quic/quic_config.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_config.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/quic_connection_stats.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M net/quic/quic_dispatcher.h View 2 chunks +12 lines, -1 line 0 comments Download
M net/quic/quic_dispatcher.cc View 3 chunks +54 lines, -26 lines 0 comments Download
M net/quic/quic_fec_group.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_fec_group.cc View 9 chunks +18 lines, -19 lines 0 comments Download
M net/quic/quic_fec_group_test.cc View 11 chunks +59 lines, -49 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 3 chunks +1 line, -6 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +13 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +15 lines, -2 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 2 chunks +12 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 3 chunks +54 lines, -26 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 4 chunks +15 lines, -4 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 2 chunks +17 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-07 02:06:02 UTC) #1
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-07 03:18:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990533002/1
5 years, 9 months ago (2015-03-07 06:20:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 08:21:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990533002/1
5 years, 9 months ago (2015-03-07 15:56:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 17:57:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990533002/1
5 years, 9 months ago (2015-03-08 05:04:39 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-08 06:07:23 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-08 06:08:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e0fb50a74c11981a86c18ad507ece44735b3b98
Cr-Commit-Position: refs/heads/master@{#319581}

Powered by Google App Engine
This is Rietveld 408576698