Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 99053008: Rename apps::AppShell* to apps::Shell* (Closed)

Created:
7 years ago by James Cook
Modified:
7 years ago
Reviewers:
miket_OOO
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, Daniel Erat
Visibility:
Public.

Description

Rename apps::AppShell* to apps::Shell* The names are getting long and unwieldy and everything is in the apps namespace anyway. This is consistent with the ash_shell and content_shell naming conventions. BUG=None TEST=compiles R=miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240742

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -1044 lines) Patch
M apps/apps.gypi View 1 chunk +15 lines, -15 lines 0 comments Download
D apps/shell/app_shell_app_sorting.h View 1 chunk +0 lines, -64 lines 0 comments Download
D apps/shell/app_shell_app_sorting.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D apps/shell/app_shell_browser_context.h View 1 chunk +0 lines, -38 lines 0 comments Download
D apps/shell/app_shell_browser_context.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D apps/shell/app_shell_browser_main_parts.h View 1 chunk +0 lines, -73 lines 0 comments Download
D apps/shell/app_shell_browser_main_parts.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D apps/shell/app_shell_content_browser_client.h View 1 chunk +0 lines, -37 lines 0 comments Download
D apps/shell/app_shell_content_browser_client.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D apps/shell/app_shell_content_client.h View 1 chunk +0 lines, -30 lines 0 comments Download
D apps/shell/app_shell_content_client.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D apps/shell/app_shell_extensions_browser_client.h View 1 chunk +0 lines, -57 lines 0 comments Download
D apps/shell/app_shell_extensions_browser_client.cc View 1 chunk +0 lines, -108 lines 0 comments Download
D apps/shell/app_shell_main.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D apps/shell/app_shell_main_delegate.h View 1 chunk +0 lines, -38 lines 0 comments Download
D apps/shell/app_shell_main_delegate.cc View 1 chunk +0 lines, -43 lines 0 comments Download
A + apps/shell/shell_app_sorting.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + apps/shell/shell_app_sorting.cc View 2 chunks +21 lines, -21 lines 0 comments Download
A + apps/shell/shell_browser_context.h View 3 chunks +7 lines, -7 lines 0 comments Download
A apps/shell/shell_browser_context.cc View 1 chunk +59 lines, -0 lines 0 comments Download
A + apps/shell/shell_browser_main_parts.h View 3 chunks +12 lines, -12 lines 0 comments Download
A + apps/shell/shell_browser_main_parts.cc View 6 chunks +16 lines, -16 lines 0 comments Download
A + apps/shell/shell_content_browser_client.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + apps/shell/shell_content_browser_client.cc View 1 chunk +8 lines, -8 lines 0 comments Download
A + apps/shell/shell_content_client.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + apps/shell/shell_content_client.cc View 2 chunks +8 lines, -8 lines 0 comments Download
A + apps/shell/shell_extensions_browser_client.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + apps/shell/shell_extensions_browser_client.cc View 3 chunks +18 lines, -19 lines 0 comments Download
A + apps/shell/shell_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + apps/shell/shell_main_delegate.h View 2 chunks +11 lines, -11 lines 0 comments Download
A + apps/shell/shell_main_delegate.cc View 2 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Cook
miket, PTAL. Dan and I talked about this - we think shorter file and class ...
7 years ago (2013-12-13 19:44:34 UTC) #1
miket_OOO
Concept LGTM. Actual changes rubber-stamp LGTM.
7 years ago (2013-12-13 20:31:42 UTC) #2
James Cook
7 years ago (2013-12-13 20:52:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r240742 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698