Only allow temporary IPv6 address.

Only allow temporary IPv6 address.

BUG=413437
Committed: https://crrev.com/30816d9aa5e2a8143d16dfb3f8110ff458c7354f
Cr-Commit-Position: refs/heads/master@{#319596}

[guoweis_left_chromium, 2015-03-06 23:57:52]

guoweis@chromium.org changed reviewers:
+ juberti@chromium.org

[guoweis_left_chromium, 2015-03-06 23:57:53]

PTAL.

[guoweis_left_chromium, 2015-03-07 00:04:41]

Did another test - somehow a temp/deprecated address shows up. This is not
what I expected. I'll dig it further.

On Fri, Mar 6, 2015 at 3:57 PM, <guoweis@chromium.org> wrote:

> Reviewers: juberti2,
>
> Message:
> PTAL.
>
> Description:
> Only allow temporary IPv6 address.
>
> BUG=413437
>
> Please review this at https://codereview.chromium.org/990503002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+5, -0 lines):
>   M content/renderer/p2p/ipc_network_manager.cc
>
>
> Index: content/renderer/p2p/ipc_network_manager.cc
> diff --git a/content/renderer/p2p/ipc_network_manager.cc
> b/content/renderer/p2p/ipc_network_manager.cc
> index ac7661209b516e1106ea249b8c002ffeb83ddfbf..
> cbad0692835060b65da861eb2eedf7324d7fb379 100644
> --- a/content/renderer/p2p/ipc_network_manager.cc
> +++ b/content/renderer/p2p/ipc_network_manager.cc
> @@ -88,6 +88,11 @@ void IpcNetworkManager::OnNetworkListChanged(
>        network->AddIP(rtc::IPAddress(address));
>        networks.push_back(network);
>      } else if (it->address.size() == net::kIPv6AddressSize) {
> +
> +      // Only allow temporary address. crbug.com/413437
> +      if (!(it->ip_address_attributes & net::IP_ADDRESS_ATTRIBUTE_
> TEMPORARY))
> +        continue;
> +
>        in6_addr address;
>        memcpy(&address, &it->address[0], sizeof(in6_addr));
>        rtc::IPAddress ip6_addr(address);
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[juberti2, 2015-03-07 00:29:54]

lgtm

https://codereview.chromium.org/990503002/diff/20001/content/renderer/p2p/ipc...
File content/renderer/p2p/ipc_network_manager.cc (right):

https://codereview.chromium.org/990503002/diff/20001/content/renderer/p2p/ipc...
content/renderer/p2p/ipc_network_manager.cc:92: // Only allow temporary address.
crbug.com/413437
suggest mentioning "to ensure the MAC is not included in the address"

[guoweis_left_chromium, 2015-03-07 02:58:58]

The CQ bit was checked by guoweis@chromium.org

[guoweis_left_chromium, 2015-03-07 02:58:58]

The patchset sent to the CQ was uploaded after l-g-t-m from juberti@chromium.org
Link to the patchset: https://codereview.chromium.org/990503002/#ps60001 (title:
" ")

[commit-bot: I haz the power, 2015-03-07 02:59:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/990503002/60001

[commit-bot: I haz the power, 2015-03-07 02:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-07 02:59:35]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[guoweis_left_chromium, 2015-03-07 03:10:14]

guoweis@chromium.org changed reviewers:
+ sergeyu@chromium.org
- juberti@chromium.org

[guoweis_left_chromium, 2015-03-07 03:10:14]

sergeyu, could you lgtm this?

[Sergey Ulanov, 2015-03-08 16:35:27]

lgtm

https://codereview.chromium.org/990503002/diff/60001/content/renderer/p2p/ipc...
File content/renderer/p2p/ipc_network_manager.cc (right):

https://codereview.chromium.org/990503002/diff/60001/content/renderer/p2p/ipc...
content/renderer/p2p/ipc_network_manager.cc:93: // included in the address.
crbug.com/413437
I can't access this bug. Please remove this link. It's not useful to refer to
non-public bugs in code.

https://codereview.chromium.org/990503002/diff/60001/content/renderer/p2p/ipc...
content/renderer/p2p/ipc_network_manager.cc:96: continue;
add {} please

[guoweis_left_chromium, 2015-03-08 16:53:43]

The CQ bit was checked by guoweis@chromium.org

[guoweis_left_chromium, 2015-03-08 16:53:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, juberti@chromium.org
Link to the patchset: https://codereview.chromium.org/990503002/#ps80001 (title:
" ")

[commit-bot: I haz the power, 2015-03-08 16:53:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/990503002/80001

[commit-bot: I haz the power, 2015-03-08 17:44:15]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-08 17:44:59]

Patchset 5 (id:??) landed as
https://crrev.com/30816d9aa5e2a8143d16dfb3f8110ff458c7354f
Cr-Commit-Position: refs/heads/master@{#319596}