Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: sky/tools/webkitpy/layout_tests/port/base.py

Issue 990493002: Make package: work like Dart expects in preparation for a Sky SDK (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Made deploy_sdk 100x faster in the --dev-environment case Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sky/sdk/README.md ('K') | « sky/tools/skypy/skyserver.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/webkitpy/layout_tests/port/base.py
diff --git a/sky/tools/webkitpy/layout_tests/port/base.py b/sky/tools/webkitpy/layout_tests/port/base.py
index 48af97524f4cdc1f2c01c83ab4dc00ea4b278962..51f3569b34a906f123a2393267d54d886728ccd9 100644
--- a/sky/tools/webkitpy/layout_tests/port/base.py
+++ b/sky/tools/webkitpy/layout_tests/port/base.py
@@ -1089,6 +1089,12 @@ class Port(object):
be the case when the tests aren't run on the host platform."""
return True
+ def _sky_sdk_path(self):
+ return self._build_path('gen/sky_sdk')
+
+ def _dart_packages_root(self):
+ return os.path.join(self._sky_sdk_path(), 'packages_root')
+
def server_command_line(self):
path = (self._options.path_to_server or
self.path_from_chromium_base('out', 'downloads', 'sky_server'))
@@ -1097,6 +1103,7 @@ class Port(object):
'-t', self.get_option('configuration'),
self.path_from_chromium_base(),
'8000',
+ self._dart_packages_root()
]
def start_http_server(self, additional_dirs, number_of_drivers):
@@ -1105,6 +1112,17 @@ class Port(object):
Ports can stub this out if they don't need a web server to be running."""
assert not self._http_server, 'Already running an http server.'
subprocess.call(self.path_to_script('download_sky_server'))
+ print # Make blank line before calling deploy_sdk.
+ subprocess.call([
+ self.path_to_script('deploy_sdk.py'),
+ '--build-dir', self._build_path(),
+ '--force',
+ '--dev-environment',
+ self._sky_sdk_path(),
+ '--fake-pub-get-into',
+ self._dart_packages_root()
+ ])
+
self._http_server = subprocess.Popen(self.server_command_line())
def start_websocket_server(self):
« sky/sdk/README.md ('K') | « sky/tools/skypy/skyserver.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698