Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: sky/tools/skydb

Issue 990493002: Make package: work like Dart expects in preparation for a Sky SDK (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Made deploy_sdk 100x faster in the --dev-environment case Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/tools/skydb
diff --git a/sky/tools/skydb b/sky/tools/skydb
index b3b67db2cb9675cfb90d0feb860e58a310acbbe7..5c23eee9203b7dfe3224578f465731e356a260ce 100755
--- a/sky/tools/skydb
+++ b/sky/tools/skydb
@@ -139,13 +139,12 @@ class SkyDebugger(object):
return shell_command
- def sky_server_for_args(self, args):
+ def sky_server_for_args(self, args, packages_root):
# FIXME: This is a hack. sky_server should just take a build_dir
# not a magical "configuration" name.
configuration = os.path.basename(os.path.normpath(self.paths.build_dir))
server_root = self._server_root_for_url(args.url_or_path)
- sky_server = SkyServer(SKY_SERVER_PORT, configuration, server_root)
- return sky_server
+ return SkyServer(SKY_SERVER_PORT, configuration, server_root, packages_root)
def _create_paths_for_build_dir(self, build_dir):
# skypy.paths.Paths takes a root-relative build_dir argument. :(
@@ -188,7 +187,18 @@ class SkyDebugger(object):
print "Cannot debug Release builds on Android"
sys.exit(2)
- sky_server = self.sky_server_for_args(args)
+ sdk_root = os.path.join(self.paths.build_dir, 'gen', 'sky_sdk')
+ packages_root = os.path.join(sdk_root, 'packages_root')
+ subprocess.check_call([
+ os.path.join(self.paths.sky_tools_directory, 'deploy_sdk.py'),
+ '--build-dir', self.paths.build_dir,
+ '--force',
+ '--dev-environment',
+ '--fake-pub-get-into', packages_root,
+ sdk_root,
+ ])
+
+ sky_server = self.sky_server_for_args(args, packages_root)
self.pids['sky_server_pid'] = sky_server.start()
self.pids['sky_server_port'] = sky_server.port
self.pids['sky_server_root'] = sky_server.root
« sky/sdk/README.md ('K') | « sky/tools/deploy_sdk.py ('k') | sky/tools/skygo/sky_server.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698