sky/engine/core/script/dart_loader.cc - Issue 990493002: Make package: work like Dart expects in preparation for a Sky SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/script/dart_loader.cc

Issue 990493002: Make package: work like Dart expects in preparation for a Sky SDK (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Made deploy_sdk 100x faster in the --dev-environment case Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/script/dart_loader.cc

diff --git a/sky/engine/core/script/dart_loader.cc b/sky/engine/core/script/dart_loader.cc

index 62a72ea0bcce5fdf92917fc7e631448db01ced12..9ae0a3e9b9dca3217af4c95e71e241b473253cec 100644

--- a/sky/engine/core/script/dart_loader.cc

+++ b/sky/engine/core/script/dart_loader.cc

@@ -30,7 +30,7 @@ Dart_Handle CanonicalizeURL(DartState* state,

return url;

// TODO(dart): Figure out how 'package:' should work in sky.

if (string.startsWith("package:")) {

- string.replace("package:", "/gen/");

+ string.replace("package:", "/packages/");

}

String library_url_string = StringFromDart(Dart_LibraryUrl(library));

KURL library_url = KURL(ParsedURLString, library_url_string);