Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 990483002: ozone: evdev: Fix possibility of stuck keys with libevdev (Closed)

Created:
5 years, 9 months ago by spang
Modified:
5 years, 9 months ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Fix possibility of stuck keys with libevdev Same as previous unplug fix, but for the libevdev/gestures path. This applies to hybrid keyboards with attached mouse/touchpad. The SYN_DROPPED part is N/A because that is handled by libevdev. BUG=463002 TEST=Tested unplug by unplugging devices with shift held. Shift gets properly released rather than being stuck. (NB: Could not reproduce without adding a delay to expose the race). Committed: https://crrev.com/d415c687891e096b3e2d10e656842d59a86a51ea Cr-Commit-Position: refs/heads/master@{#319673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -19 lines) Patch
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 5 chunks +25 lines, -13 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_timer_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_timer_provider.cc View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
spang
5 years, 9 months ago (2015-03-06 23:41:21 UTC) #2
spang
5 years, 9 months ago (2015-03-09 16:40:04 UTC) #4
kpschoedel
I'd travel two thousand miles just to LGTM this patch.
5 years, 9 months ago (2015-03-09 17:05:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990483002/1
5 years, 9 months ago (2015-03-09 17:18:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 17:43:23 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 17:43:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d415c687891e096b3e2d10e656842d59a86a51ea
Cr-Commit-Position: refs/heads/master@{#319673}

Powered by Google App Engine
This is Rietveld 408576698