chrome/browser/resources/settings/pref_tracker/pref_tracker.js - Issue 990473002: Add initial implementation of date-time-settings MD settings page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/pref_tracker/pref_tracker.js

Issue 990473002: Add initial implementation of date-time-settings MD settings page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/pref_tracker/pref_tracker.js

diff --git a/chrome/browser/resources/settings/pref_tracker/pref_tracker.js b/chrome/browser/resources/settings/pref_tracker/pref_tracker.js

index 104b18626e8f9cabb4ca0f390208ae50bcea8a5c..29fa6ef22cab39776fe2ed96d42f019e0c02269e 100644

--- a/chrome/browser/resources/settings/pref_tracker/pref_tracker.js

+++ b/chrome/browser/resources/settings/pref_tracker/pref_tracker.js

@@ -74,7 +74,7 @@

var parentPrefString = this.parentNode && this.parentNode.host &&

this.parentNode.host.getAttribute('pref');

if (parentPrefString) {

- keyHint = parentPrefString.match(/{{([a-z._]+)}}/)[1];

+ keyHint = parentPrefString.match(/{{([a-z0-9._]+)}}/)[1];

}

throw new Error('Pref not found. Key Hint: ' + keyHint);

« no previous file with comments | « chrome/browser/resources/settings/date_time_page/demo.js ('k') | chrome/browser/resources/settings/prefs/prefs.js » ('j') | no next file with comments »