chrome/browser/resources/settings/date_time_page/date_time_page.html - Issue 990473002: Add initial implementation of date-time-settings MD settings page.

Side by Side Diff: chrome/browser/resources/settings/date_time_page/date_time_page.html

Issue 990473002: Add initial implementation of date-time-settings MD settings page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update layout to reflect new changes. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/date_time_page/date_time_page.css ('K') | « chrome/browser/resources/settings/date_time_page/date_time_page.css ('k') | chrome/browser/resources/settings/date_time_page/date_time_page.js » ('j') | chrome/browser/resources/settings/date_time_page/date_time_page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://md-settings/checkbox/checkbox.html">

	2 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	3 <link rel="import" href="chrome://resources/polymer/core-label/core-label.html">

	4 <link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">

	5 <link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html">

	6 <link rel="import" href="chrome://resources/polymer/paper-shadow/paper-shadow.ht ml">

	7 <link rel="import" href="chrome://resources/cr_elements/cr_checkbox/cr_checkbox.
	michaelpg 2015/03/24 00:43:37 remove remove Oren Blasberg 2015/03/24 00:54:57 Done. Show quoted text On 2015/03/24 00:43:37, michaelpg wrote: > remove Done.
	8 html">

	9 <link rel="import" href="chrome://resources/cr_elements/cr_dropdown_menu/

	10 cr_dropdown_menu.html">

	11

	12 <polymer-element name="cr-settings-date-time-page">

	13 <template>

	14 <link rel="stylesheet" href="chrome://md-settings/settings_page/settings_pag e.css">

	15 <link rel="stylesheet" href="date_time_page.css">

	16 <paper-shadow layout vertical cross-fade>

	17 <cr-settings-page-header page="{{}}"></cr-settings-page-header>

	18 <div horizontal layout center>

	19 <core-label horizontal layout center>

	20 <span class="time-zone-label">Time zone:</span>

	21 <cr-dropdown-menu id="timezoneMenu">

	22 <core-menu class="menu" valueAttr="value" selectedAttribute=""

	23 selected="{{prefs.settings.cros.system.timezone}}">

	24 <paper-item value="America/Los_Angeles">

	25 Pacific Standard Time

	26 </paper-item>

	27 <paper-item value="America/New_York">

	28 Eastern Standard Time

	29 </paper-item>

	30 </core-menu>

	31 </cr-dropdown-menu>

	32 </core-label>

	33 </div>

	34 <cr-settings-checkbox

	35 pref="{{prefs.settings.clock.use24HourClock}}"
	Jeremy Klein 2015/03/24 00:49:05 camelCase -> under-scores camelCase -> under-scores Jeremy Klein 2015/03/24 00:49:06 Ugh I actually think this might need to be prefs.s Ugh I actually think this might need to be prefs.settings.settings.clock.use_24Hour_clock. The duplicate "settings" is annoying, but the actual path here is "settings.clock.use_24Hour_clock". Oren Blasberg 2015/03/24 00:54:57 Done. Show quoted text On 2015/03/24 00:49:06, Jeremy Klein wrote: > Ugh I actually think this might need to be > prefs.settings.settings.clock.use_24Hour_clock. > > The duplicate "settings" is annoying, but the actual path here is > "settings.clock.use_24Hour_clock". Done.
	36 label="Use 24-hour clock">
	michaelpg 2015/03/24 00:43:37 optional nit: condense optional nit: condense Oren Blasberg 2015/03/24 00:54:57 condense -> just over 80char :( Show quoted text On 2015/03/24 00:43:37, michaelpg wrote: > optional nit: condense condense -> just over 80char :(
	37 </cr-settings-checkbox>

	38 <span id="setAutomatically">Date and time are set automatically.</span>

	39 </paper-shadow>

	40 </template>

	41 <script src="date_time_page.js"></script>

	42 </polymer-element>

OLD	NEW