chrome/browser/resources/settings/date_time_page/date_time_page.html - Issue 990473002: Add initial implementation of date-time-settings MD settings page.

Side by Side Diff: chrome/browser/resources/settings/date_time_page/date_time_page.html

Issue 990473002: Add initial implementation of date-time-settings MD settings page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up a couple things Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/date_time_page/date_time_page.css ('K') | « chrome/browser/resources/settings/date_time_page/date_time_page.css ('k') | chrome/browser/resources/settings/date_time_page/date_time_page.js » ('j') | chrome/browser/resources/settings/date_time_page/date_time_page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/core-label/core-label.html">

	3 <link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">

	4 <link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html">

	5 <link rel="import" href="chrome://resources/cr_elements/cr_checkbox/cr_checkbox.

	6 html">

	7 <link rel="import" href="chrome://resources/cr_elements/cr_dropdown_menu/

	8 cr_dropdown_menu.html">

	9

	10 <polymer-element name="cr-settings-date-time-page" layout vertical>

	11 <template>

	12 <link rel="stylesheet" href="date_time_page.css">

	13 <div horizontal layout center>

	14 <core-label horizontal layout center>

	15 <span class="time-zone-label">Time zone:</span>

	16 <cr-dropdown-menu id="timezoneMenu">

	17 <core-menu class="menu" valueAttr="value" selectedAttribute=""

	18 selected="{{prefs.settings.dateTime.timezone}}">

	19 <paper-item value="America/Los_Angeles">

	20 Pacific Standard Time
	michaelpg 2015/03/08 05:57:08 DST begins in four hours!!1! Better change these q DST begins in four hours!!1! Better change these quick. Oren Blasberg 2015/03/10 01:25:01 I can leave it as is since it's just a placeholder Show quoted text On 2015/03/08 05:57:08, michaelpg wrote: > DST begins in four hours!!1! Better change these quick. I can leave it as is since it's just a placeholder anyway right? michaelpg 2015/03/10 03:22:29 Yes, I was just kidding! Show quoted text On 2015/03/10 01:25:01, Oren Blasberg wrote: > On 2015/03/08 05:57:08, michaelpg wrote: > > DST begins in four hours!!1! Better change these quick. > > I can leave it as is since it's just a placeholder anyway right? Yes, I was just kidding! Oren Blasberg 2015/03/24 00:37:48 :) Show quoted text On 2015/03/10 03:22:29, michaelpg wrote: > On 2015/03/10 01:25:01, Oren Blasberg wrote: > > On 2015/03/08 05:57:08, michaelpg wrote: > > > DST begins in four hours!!1! Better change these quick. > > > > I can leave it as is since it's just a placeholder anyway right? > > Yes, I was just kidding! :)
	21 </paper-item>

	22 <paper-item value="America/New_York">

	23 Eastern Standard Time

	24 </paper-item>

	25 </core-menu>

	26 </cr-dropdown-menu>

	27 </core-label>

	28 </div>

	29 <core-label horizontal layout>

	30 <cr-checkbox checked="{{prefs.settings.dateTime.use24HourClock}}" for>
	Jeremy Klein 2015/03/06 23:26:44 It seems like these don't actually match their pre It seems like these don't actually match their pref values: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res... I thought we had decided to just use the full pref path for now. Oren Blasberg 2015/03/10 01:25:01 I updated this to 'clock'. However, note that time Show quoted text On 2015/03/06 23:26:44, Jeremy Klein wrote: > It seems like these don't actually match their pref values: > > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res... > > I thought we had decided to just use the full pref path for now. I updated this to 'clock'. However, note that timezone (from the link you sent me) doesn't start with 'prefs' or 'settings' : instead, it's "cros.system.timezone". How should we modify our model accordingly? Michael? Does it make sense to do something like, add "cros" or "system" to the prefs.js published properties, in addition to just "settings"? michaelpg 2015/03/10 03:22:29 This is a device property as opposed to a preferen Show quoted text On 2015/03/10 01:25:01, Oren Blasberg wrote: > On 2015/03/06 23:26:44, Jeremy Klein wrote: > > It seems like these don't actually match their pref values: > > > > > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res... > > > > I thought we had decided to just use the full pref path for now. > > I updated this to 'clock'. However, note that timezone (from the link you sent > me) doesn't start with 'prefs' or 'settings' : instead, it's > "cros.system.timezone". > > How should we modify our model accordingly? > Michael? Does it make sense to do something like, add "cros" or "system" to the > prefs.js published properties, in addition to just "settings"? This is a device property as opposed to a preference. We may have a separate API for these settings when we start building the new preferences API. But settings.cros.system.timezone is fine for now.
	31 </cr-checkbox>

	32 <span>Use 24-hour clock</span>

	33 </core-label>

	34 <span id="setAutomatically">Date and time are set automatically.</span>

	35 </template>

	36 <script src="date_time_page.js"></script>

	37 </polymer-element>

OLD	NEW