Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 990463002: [autofill] Query credit card scanning feature once per browser process. (Closed)

Created:
5 years, 9 months ago by please use gerrit instead
Modified:
5 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[autofill] Query credit card scanning feature once per browser process. Checking whether credit card scanning is possible can be an expensive operation. The result of this call is unlikely to change during the lifetime of a browser process. This patch will query credit card scanning feature once when the user types in a credit card input field for the first time. Restarting the browser process is necessary to clear the cache. BUG=461944 Committed: https://crrev.com/f159055ebd535230ccd05791c9852c5d558248ed Cr-Commit-Position: refs/heads/master@{#319670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/autofill/credit_card_scanner_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
please use gerrit instead
Evan, PTAL.
5 years, 9 months ago (2015-03-06 23:14:52 UTC) #2
Evan Stade
lgtm
5 years, 9 months ago (2015-03-06 23:20:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990463002/1
5 years, 9 months ago (2015-03-06 23:28:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 01:04:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990463002/1
5 years, 9 months ago (2015-03-09 16:40:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 17:35:27 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 17:36:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f159055ebd535230ccd05791c9852c5d558248ed
Cr-Commit-Position: refs/heads/master@{#319670}

Powered by Google App Engine
This is Rietveld 408576698