Add more instrumentation to track down jank.

Add more instrumentation to track down jank.

BUG=454983
Committed: https://crrev.com/512ed18bb8de4f2c35953cc5939bb91cb42c4b8d
Cr-Commit-Position: refs/heads/master@{#319545}

[eroman, 2015-03-06 22:22:42]

eroman@chromium.org changed reviewers:
+ mmenke@chromium.org

[eroman, 2015-03-06 22:22:43]

https://codereview.chromium.org/990433003/diff/1/net/proxy/proxy_resolver_v8_...
File net/proxy/proxy_resolver_v8_tracing.cc (right):

https://codereview.chromium.org/990433003/diff/1/net/proxy/proxy_resolver_v8_...
net/proxy/proxy_resolver_v8_tracing.cc:952:
CHECK(thread_->StartWithOptions(options));
My working theory is that starting the thread is the janky action. However I
instrumented in other places just in case that theory is wrong, so I don't have
to wait for yet another canary release.

[mmenke, 2015-03-06 22:56:44]

LGTM

https://codereview.chromium.org/990433003/diff/1/chrome/browser/net/proxy_ser...
File chrome/browser/net/proxy_service_factory.cc (right):

https://codereview.chromium.org/990433003/diff/1/chrome/browser/net/proxy_ser...
chrome/browser/net/proxy_service_factory.cc:143: "454983
ProxyServiceFactory::CreateProxyService_3"));
optional nit:  Should this be just before the #ifdefined?  Even if we don't care
about ChromeOS, seems a little weird here.

Actually, there's so little between the start of "if (use_v8)" and this, seems
like this makes the most sense just after the if.

https://codereview.chromium.org/990433003/diff/1/net/proxy/proxy_resolver_v8_...
File net/proxy/proxy_resolver_v8_tracing.cc (right):

https://codereview.chromium.org/990433003/diff/1/net/proxy/proxy_resolver_v8_...
net/proxy/proxy_resolver_v8_tracing.cc:952:
CHECK(thread_->StartWithOptions(options));
On 2015/03/06 22:22:43, eroman wrote:
> My working theory is that starting the thread is the janky action. However I
> instrumented in other places just in case that theory is wrong, so I don't
have
> to wait for yet another canary release.

SGTM

[eroman, 2015-03-06 23:02:43]

https://codereview.chromium.org/990433003/diff/1/chrome/browser/net/proxy_ser...
File chrome/browser/net/proxy_service_factory.cc (right):

https://codereview.chromium.org/990433003/diff/1/chrome/browser/net/proxy_ser...
chrome/browser/net/proxy_service_factory.cc:143: "454983
ProxyServiceFactory::CreateProxyService_3"));
On 2015/03/06 22:56:44, mmenke wrote:
> optional nit:  Should this be just before the #ifdefined?  Even if we don't
care
> about ChromeOS, seems a little weird here.
> 
> Actually, there's so little between the start of "if (use_v8)" and this, seems
> like this makes the most sense just after the if.

Done.

[eroman, 2015-03-06 23:02:47]

The CQ bit was checked by eroman@chromium.org

[eroman, 2015-03-06 23:02:47]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/990433003/revert#ps20001
(title: "address matt's feedback")

[commit-bot: I haz the power, 2015-03-06 23:04:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/990433003/20001

[commit-bot: I haz the power, 2015-03-07 01:06:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-07 01:06:51]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[eroman, 2015-03-07 01:08:20]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2015-03-07 01:10:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/990433003/20001

[commit-bot: I haz the power, 2015-03-07 02:08:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-07 02:09:17]

Patchset 2 (id:??) landed as
https://crrev.com/512ed18bb8de4f2c35953cc5939bb91cb42c4b8d
Cr-Commit-Position: refs/heads/master@{#319545}