Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 99043003: Fix typeahead for popup menu with attributes (Closed)

Created:
7 years ago by Jiang Jiang
Modified:
7 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix typeahead for popup menu with attributes Popup menu item with attributes (<optgroup> for instance) will break typeahead matching support on Mac. Use the same trick Apple uses in WebKit2 [1] to fix this. BUG=90064 [1] http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm#L90 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238377

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update comment with the link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/browser/renderer_host/webmenurunner_mac.mm View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jiang Jiang
7 years ago (2013-12-02 14:39:07 UTC) #1
Avi (use Gerrit)
Sweet! LGTM with a link. https://codereview.chromium.org/99043003/diff/1/content/browser/renderer_host/webmenurunner_mac.mm File content/browser/renderer_host/webmenurunner_mac.mm (right): https://codereview.chromium.org/99043003/diff/1/content/browser/renderer_host/webmenurunner_mac.mm#newcode88 content/browser/renderer_host/webmenurunner_mac.mm:88: // what Apple uses ...
7 years ago (2013-12-02 14:53:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/99043003/20001
7 years ago (2013-12-02 15:05:55 UTC) #3
Jiang Jiang
On 2013/12/02 14:53:06, Avi wrote: > Sweet! LGTM with a link. > > https://codereview.chromium.org/99043003/diff/1/content/browser/renderer_host/webmenurunner_mac.mm > ...
7 years ago (2013-12-02 15:06:13 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195234
7 years ago (2013-12-02 15:22:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/99043003/20001
7 years ago (2013-12-03 11:21:51 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-03 12:48:49 UTC) #7
Message was sent while issue was closed.
Change committed as 238377

Powered by Google App Engine
This is Rietveld 408576698