Issue 99043002: Check elimination: Learn from if(CompareMap(x)) on true branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99043002: Check elimination: Learn from if(CompareMap(x)) on true branch. (Closed)

Created:
7 years ago by titzer

Modified:
7 years ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Check elimination: Learn from if(CompareMap(x)) on true branch. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18210

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update the copy state, not the original. #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -14 lines)			Patch
	M	src/hydrogen-check-elimination.cc	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
	A +	test/mjsunit/compiler/compare_map_elim.js	View	1	1 chunk	+20 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

LGTM with a nit. I'll leave that one up to you. https://codereview.chromium.org/99043002/diff/1/src/hydrogen-check-elimination.cc File src/hydrogen-check-elimination.cc (right): ...

7 years ago (2013-12-02 15:13:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r18210 (presubmit successful).

Expand Messages | Collapse Messages