Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 990423004: Reland Just visit young array buffers during scavenge. (Closed)

Created:
5 years, 9 months ago by Hannes Payer (out of office)
Modified:
5 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Just visit young array buffers during scavenge. Additionally keep the views in new space in a separate global list and move them to the corresponding array buffers when they get promoted. BUG= Committed: https://crrev.com/aab76eff43a116f287c15cb2412375afbd9c252e Cr-Commit-Position: refs/heads/master@{#27128}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -54 lines) Patch
M src/factory.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 5 chunks +34 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 6 chunks +54 lines, -9 lines 0 comments Download
M src/heap/objects-visiting.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/heap/objects-visiting.cc View 1 2 6 chunks +80 lines, -15 lines 0 comments Download
M src/objects.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 5 chunks +46 lines, -6 lines 0 comments Download
M src/serialize.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-weaktypedarrays.cc View 6 chunks +44 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Hannes Payer (out of office)
5 years, 9 months ago (2015-03-10 14:49:18 UTC) #2
ulan
Question https://codereview.chromium.org/990423004/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/990423004/diff/20001/src/heap/heap.cc#newcode2235 src/heap/heap.cc:2235: heap->set_migration_failure(false); Where is migration_failure set to true? https://codereview.chromium.org/990423004/diff/20001/src/heap/objects-visiting.cc ...
5 years, 9 months ago (2015-03-10 14:56:14 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/990423004/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/990423004/diff/20001/src/heap/heap.cc#newcode2235 src/heap/heap.cc:2235: heap->set_migration_failure(false); On 2015/03/10 14:56:14, ulan wrote: > Where is ...
5 years, 9 months ago (2015-03-10 15:12:24 UTC) #4
ulan
lgtm
5 years, 9 months ago (2015-03-11 09:03:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990423004/40001
5 years, 9 months ago (2015-03-11 10:19:32 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-11 10:57:59 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 10:58:16 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aab76eff43a116f287c15cb2412375afbd9c252e
Cr-Commit-Position: refs/heads/master@{#27128}

Powered by Google App Engine
This is Rietveld 408576698