Fix CheckPatchFormatted message for subdirectories

Fix CheckPatchFormatted message for subdirectories

Thanks to tfarina for the code suggestion.

BUG=443718
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294436

[enne (OOO), 2015-03-10 00:41:15]

enne@chromium.org changed reviewers:
+ iannucci@chromium.org

[enne (OOO), 2015-03-10 00:43:22]

Just taking off the basename leads to more verbose messages as it includes the
absolute path to the repository instead.  I used tfarina's suggestion from the
bug to get the relative path to the depot root.  `git cl format cc` from inside
some subdirectory still works, so absolute paths don't seem to be needed.

This patch makes the check print out messages like this:
--snip--
The service_worker directory requires source formatting. Please run git cl
format content/browser/service_worker
--snip--

[enne (OOO), 2015-03-12 21:59:03]

enne@chromium.org changed reviewers:
+ dpranke@chromium.org

[enne (OOO), 2015-03-12 21:59:31]

enne@chromium.org changed reviewers:
+ szager@chromium.org

[enne (OOO), 2015-03-12 21:59:45]

+dpranke,szager as alternate reviewers

[szager1, 2015-03-12 22:09:41]

lgtm

[enne (OOO), 2015-03-13 00:31:17]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2015-03-13 00:31:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/990403002/1

[commit-bot: I haz the power, 2015-03-13 00:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-13 00:34:35]

Presubmit check for 990403002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (53.07s) failed
Ffatal: reference is not a tree: 6b6577bcf1582f6e5cd2026ae6daae0f615a3a9a
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
6b6577bcf1582f6e5cd2026ae6daae0f615a3a9a returned non-zero exit status 128 in
/tmp/trialwDdqnI/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialwDdqnI/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialwDdqnI/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 51.847s

FAILED (failures=1, errors=2)


Presubmit checks took 184.8s to calculate.

[tfarina, 2015-03-13 18:53:04]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2015-03-13 18:53:05]

I have checked the CQ box again.

[tfarina, 2015-03-13 18:53:11]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-03-13 18:53:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/990403002/1

[commit-bot: I haz the power, 2015-03-13 18:56:56]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294436