PpapiCommandBufferProxy implements CommandBufferProxy.

PpapiCommandBufferProxy implements CommandBufferProxy.

That way once the refactoring of WebGraphicsContext3DCommandBufferImpl is complete,
the guest renderers will be able to use the same class. 

BUG=120664
TEST=manually


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130252

[Fady Samuel, 2012-03-29 00:22:32]

Hi Antoine,

This is more or less what we discussed earlier today. A simple "do nothing"
implementation of CommandBufferProxy for PpapiCommandBufferProxy. Will add to
this implementation as the need arises.

Thanks,

Fady

[Fady Samuel, 2012-03-29 20:40:05]

Hi Antoine,

Does this look OK to you for now? Will implement as need arises.

Thanks,

Fady

[piman, 2012-03-29 22:18:55]

lgtm

[commit-bot: I haz the power, 2012-03-29 22:23:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/9904005/1

[commit-bot: I haz the power, 2012-03-29 22:23:10]

Can't apply patch for file ppapi/proxy/ppapi_command_buffer_proxy.h.
While running patch -p1 --forward --force;
patching file ppapi/proxy/ppapi_command_buffer_proxy.h
Hunk #1 FAILED at 6.
Hunk #2 FAILED at 20.
Hunk #3 succeeded at 62 with fuzz 2 (offset 6 lines).
2 out of 3 hunks FAILED -- saving rejects to file
ppapi/proxy/ppapi_command_buffer_proxy.h.rej

[commit-bot: I haz the power, 2012-03-30 00:29:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/9904005/7001

[commit-bot: I haz the power, 2012-03-30 01:12:37]

Try job failure for 9904005-7001 (retry) on linux_rel for step "check_deps".
It's a second try, previously, step "check_deps" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[piman, 2012-03-30 01:15:13]

On Thu, Mar 29, 2012 at 6:12 PM, <commit-bot@chromium.org> wrote:

> Try job failure for 9904005-7001 (retry) on linux_rel for step
> "check_deps".
> It's a second try, previously, step "check_deps" failed.
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=linux_rel&**number=13942<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=13942>


Oh, right, you can't have something in pepper depend on something in
content (circular deps).
You may want to move the interface into gpu/ipc for example.

>
>
>
>
http://codereview.chromium.**org/9904005/<http://codereview.chromium.org/9904...
>

[Fady Samuel, 2012-03-30 02:04:44]

Hi Antoine,

How does this look? 

Thanks,

Fady

[piman, 2012-03-30 17:58:37]

LGTM+nit

http://codereview.chromium.org/9904005/diff/7013/gpu/ipc/command_buffer_proxy.h
File gpu/ipc/command_buffer_proxy.h (right):

http://codereview.chromium.org/9904005/diff/7013/gpu/ipc/command_buffer_proxy...
gpu/ipc/command_buffer_proxy.h:9: #if defined(ENABLE_GPU)
nit: While you're here, do you mind removing this #ifdef? It's been a long time
since we could compile without GPU support, and we've been cleaning these as we
go through code.

[Fady Samuel, 2012-03-30 18:40:05]

committing now.

https://chromiumcodereview.appspot.com/9904005/diff/7013/gpu/ipc/command_buff...
File gpu/ipc/command_buffer_proxy.h (right):

https://chromiumcodereview.appspot.com/9904005/diff/7013/gpu/ipc/command_buff...
gpu/ipc/command_buffer_proxy.h:9: #if defined(ENABLE_GPU)
On 2012/03/30 17:58:37, piman wrote:
> nit: While you're here, do you mind removing this #ifdef? It's been a long
time
> since we could compile without GPU support, and we've been cleaning these as
we
> go through code.

Done.

[commit-bot: I haz the power, 2012-03-30 18:40:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/9904005/25001

[commit-bot: I haz the power, 2012-03-30 18:40:33]

Presubmit check for 9904005-25001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content
    content/browser

Presubmit checks took 1.8s to calculate.

[Fady Samuel, 2012-03-30 20:29:17]

Adding jam@ as an OWNER. Thanks.

[jam, 2012-03-30 21:45:29]

http://codereview.chromium.org/9904005/diff/25001/gpu/ipc/command_buffer_proxy.h
File gpu/ipc/command_buffer_proxy.h (right):

http://codereview.chromium.org/9904005/diff/25001/gpu/ipc/command_buffer_prox...
gpu/ipc/command_buffer_proxy.h:5: #ifndef
CONTENT_COMMON_GPU_CLIENT_COMMAND_BUFFER_PROXY_H_
nit: update header guards

http://codereview.chromium.org/9904005/diff/25001/gpu/ipc/command_buffer_prox...
gpu/ipc/command_buffer_proxy.h:14: #include
"content/common/gpu/client/gpu_video_decode_accelerator_host.h"
this is a layering violation, the "gpu" module is below "content" and shouldn't
include it. so you can't commit this as is.

[jam, 2012-03-30 21:46:51]

http://codereview.chromium.org/9904005/diff/25001/gpu/ipc/command_buffer_proxy.h
File gpu/ipc/command_buffer_proxy.h (right):

http://codereview.chromium.org/9904005/diff/25001/gpu/ipc/command_buffer_prox...
gpu/ipc/command_buffer_proxy.h:14: #include
"content/common/gpu/client/gpu_video_decode_accelerator_host.h"
On 2012/03/30 21:45:29, John Abd-El-Malek wrote:
> this is a layering violation, the "gpu" module is below "content" and
shouldn't
> include it. so you can't commit this as is.

btw the "checkdeps" failure on the try run is trying o tell you this too :)

[Fady Samuel, 2012-04-02 01:01:09]

Hi Antoine, John,

I've removed CreateVideoDecoder from the CommandBufferProxy interface, to
address the layering violation that John pointed out. Does this look reasonable?

John, does this look OK to you as well?

Thanks,

Fady

https://chromiumcodereview.appspot.com/9904005/diff/25001/gpu/ipc/command_buf...
File gpu/ipc/command_buffer_proxy.h (right):

https://chromiumcodereview.appspot.com/9904005/diff/25001/gpu/ipc/command_buf...
gpu/ipc/command_buffer_proxy.h:5: #ifndef
CONTENT_COMMON_GPU_CLIENT_COMMAND_BUFFER_PROXY_H_
On 2012/03/30 21:45:29, John Abd-El-Malek wrote:
> nit: update header guards

Done.

https://chromiumcodereview.appspot.com/9904005/diff/25001/gpu/ipc/command_buf...
gpu/ipc/command_buffer_proxy.h:14: #include
"content/common/gpu/client/gpu_video_decode_accelerator_host.h"
On 2012/03/30 21:45:29, John Abd-El-Malek wrote:
> this is a layering violation, the "gpu" module is below "content" and
shouldn't
> include it. so you can't commit this as is.

Done.

[jam, 2012-04-02 16:25:00]

lgtm

[piman, 2012-04-02 17:28:40]

lgtm

[commit-bot: I haz the power, 2012-04-02 17:29:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/9904005/19029

[commit-bot: I haz the power, 2012-04-02 18:15:19]

Try job failure for 9904005-19029 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-04-02 20:10:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/9904005/20019

[commit-bot: I haz the power, 2012-04-02 23:32:39]

Change committed as 130252