drawPicture calls OnDrawPicture calls drawPicture

drawPicture calls OnDrawPicture calls drawPicture

Ran into infinite recursion while looking at skia benchmarked skpictures
in trace viewer.  BenchmarkingCanvas::onDrawPicture was calling
SkCanvas::drawPicture, which would call BenchmarkingCanvas::onDrawPicture.

BenchmarkingCanvas::onDrawPicture now calls SkCanvas::onDrawPicture,
which should break up pictures into multiple commands.

Committed: https://crrev.com/535b4f0be7b7edde9874e8b6ac1519afe44f6db5
Cr-Commit-Position: refs/heads/master@{#319811}

[hendrikw, 2015-03-09 23:10:56]

hendrikw@chromium.org changed reviewers:
+ fmalita@chromium.org

[hendrikw, 2015-03-09 23:10:57]

PTAL, I think this is correct.

It might be nice if we also benchmarked the end of the DrawPicture so that we
can see what commands are internal to the DrawPicture  (better yet would be the
ability to collapse these)

[f(malita), 2015-03-10 00:26:40]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2015-03-10 00:26:41]

lgtm

[commit-bot: I haz the power, 2015-03-10 00:27:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/990373002/1

[f(malita), 2015-03-10 00:29:08]

On 2015/03/09 23:10:57, hendrikw wrote:
> It might be nice if we also benchmarked the end of the DrawPicture so that we
> can see what commands are internal to the DrawPicture  (better yet would be
the
> ability to collapse these)

Agreed, the current presentation is not ideal. At the very least we should have
some beginPicture/endPicture markers to bracket the picture commands.

[commit-bot: I haz the power, 2015-03-10 01:47:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-10 01:48:27]

Patchset 1 (id:??) landed as
https://crrev.com/535b4f0be7b7edde9874e8b6ac1519afe44f6db5
Cr-Commit-Position: refs/heads/master@{#319811}