Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 990373002: drawPicture calls OnDrawPicture calls drawPicture (Closed)

Created:
5 years, 9 months ago by hendrikw
Modified:
5 years, 9 months ago
Reviewers:
f(malita)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

drawPicture calls OnDrawPicture calls drawPicture Ran into infinite recursion while looking at skia benchmarked skpictures in trace viewer. BenchmarkingCanvas::onDrawPicture was calling SkCanvas::drawPicture, which would call BenchmarkingCanvas::onDrawPicture. BenchmarkingCanvas::onDrawPicture now calls SkCanvas::onDrawPicture, which should break up pictures into multiple commands. Committed: https://crrev.com/535b4f0be7b7edde9874e8b6ac1519afe44f6db5 Cr-Commit-Position: refs/heads/master@{#319811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M skia/ext/benchmarking_canvas.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
hendrikw
PTAL, I think this is correct. It might be nice if we also benchmarked the ...
5 years, 9 months ago (2015-03-09 23:10:57 UTC) #2
f(malita)
lgtm
5 years, 9 months ago (2015-03-10 00:26:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990373002/1
5 years, 9 months ago (2015-03-10 00:27:36 UTC) #5
f(malita)
On 2015/03/09 23:10:57, hendrikw wrote: > It might be nice if we also benchmarked the ...
5 years, 9 months ago (2015-03-10 00:29:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 01:47:23 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 01:48:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/535b4f0be7b7edde9874e8b6ac1519afe44f6db5
Cr-Commit-Position: refs/heads/master@{#319811}

Powered by Google App Engine
This is Rietveld 408576698