content/browser/renderer_host/media/audio_input_device_manager.cc - Issue 99033003: Enable platform echo cancellation through the AudioRecord path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_input_device_manager.cc

Issue 99033003: Enable platform echo cancellation through the AudioRecord path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/renderer_host/media/audio_input_device_manager_unittest.cc » ('j') | content/renderer/media/media_stream_dependency_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/audio_input_device_manager.cc

diff --git a/content/browser/renderer_host/media/audio_input_device_manager.cc b/content/browser/renderer_host/media/audio_input_device_manager.cc

index 00cd4354ae37811852451996fa47f38a053ef497..3679ad0f257d8a8a9693edaccc792d97bb61c66e 100644

--- a/content/browser/renderer_host/media/audio_input_device_manager.cc

+++ b/content/browser/renderer_host/media/audio_input_device_manager.cc

@@ -35,7 +35,7 @@ AudioInputDeviceManager::AudioInputDeviceManager(

media::AudioManagerBase::kDefaultDeviceName,

media::AudioManagerBase::kDefaultDeviceId,

44100, media::CHANNEL_LAYOUT_STEREO,

- 0);

+ 0, false);

fake_device.session_id = kFakeOpenSessionId;

devices_.push_back(fake_device);

}

@@ -170,7 +170,7 @@ void AudioInputDeviceManager::OpenOnDeviceThread(

DCHECK(IsOnDeviceThread());

StreamDeviceInfo out(info.device.type, info.device.name, info.device.id,

- 0, 0, 0);

+ 0, 0, 0, false);

out.session_id = session_id;

MediaStreamDevice::AudioDeviceParameters& input_params = out.device.input;

@@ -187,6 +187,7 @@ void AudioInputDeviceManager::OpenOnDeviceThread(

input_params.sample_rate = params.sample_rate();

input_params.channel_layout = params.channel_layout();

input_params.frames_per_buffer = params.frames_per_buffer();

+ input_params.use_platform_aec = params.use_platform_aec();

// Add preferred output device information if a matching output device

// exists.