content/renderer/media/webrtc_audio_device_unittest.cc - Issue 99033003: Enable platform echo cancellation through the AudioRecord path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_device_unittest.cc

Issue 99033003: Enable platform echo cancellation through the AudioRecord path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests and remove SetDiscreteChannels. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc_audio_capturer_unittest.cc ('k') | content/renderer/media/webrtc_local_audio_track_unittest.cc » ('j') | media/audio/android/audio_android_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_audio_device_unittest.cc

diff --git a/content/renderer/media/webrtc_audio_device_unittest.cc b/content/renderer/media/webrtc_audio_device_unittest.cc

index 5e111a5268f629b8fcdfc154e7804a961f15a9c8..1ab3eb0dd7993ad49d08f39e01d4b178f2d90635 100644

--- a/content/renderer/media/webrtc_audio_device_unittest.cc

+++ b/content/renderer/media/webrtc_audio_device_unittest.cc

@@ -120,7 +120,8 @@ bool CreateAndInitializeCapturer(WebRtcAudioDeviceImpl* webrtc_audio_device) {

media::ChannelLayout channel_layout =

hardware_config->GetInputChannelLayout();

if (!capturer->Initialize(kRenderViewId, channel_layout, sample_rate, 0, 1,

- media::AudioManagerBase::kDefaultDeviceId, 0 ,0)) {

+ media::AudioManagerBase::kDefaultDeviceId, 0, 0,

+ media::AudioParameters::NO_EFFECTS)) {

return false;

}