content/renderer/media/webrtc_audio_capturer_unittest.cc - Issue 99033003: Enable platform echo cancellation through the AudioRecord path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_capturer_unittest.cc

Issue 99033003: Enable platform echo cancellation through the AudioRecord path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add PlatformEffects, unittests and clean up. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/webrtc_audio_capturer.cc ('K') | « content/renderer/media/webrtc_audio_capturer.cc ('k') | content/renderer/media/webrtc_audio_device_unittest.cc » ('j') | media/audio/android/audio_android_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_audio_capturer_unittest.cc

diff --git a/content/renderer/media/webrtc_audio_capturer_unittest.cc b/content/renderer/media/webrtc_audio_capturer_unittest.cc

index cc7d528912567736b513c9aaf1d0a5f754b60882..8ad12a3237a45d6ed8be94bddf00dc1f5fd84fc0 100644

--- a/content/renderer/media/webrtc_audio_capturer_unittest.cc

+++ b/content/renderer/media/webrtc_audio_capturer_unittest.cc

@@ -95,13 +95,16 @@ class WebRtcAudioCapturerTest : public testing::Test {

media::CHANNEL_LAYOUT_STEREO, 48000, 16, 128) {

#endif

capturer_ = WebRtcAudioCapturer::CreateCapturer();

+ media::AudioParameters::PlatformEffects effects;

capturer_->Initialize(-1, params_.channel_layout(), params_.sample_rate(),

- params_.frames_per_buffer(), 0, std::string(), 0, 0);

+ params_.frames_per_buffer(), 0, std::string(), 0, 0,

+ effects);

capturer_source_ = new MockCapturerSource();

EXPECT_CALL(*capturer_source_.get(), Initialize(_, capturer_.get(), 0));

capturer_->SetCapturerSource(capturer_source_,

params_.channel_layout(),

- params_.sample_rate());

+ params_.sample_rate(),

+ effects);

EXPECT_CALL(*capturer_source_.get(), SetAutomaticGainControl(true));

EXPECT_CALL(*capturer_source_.get(), Start());