Enable platform echo cancellation through the AudioRecord path.

content/public/common/media_stream_request.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_MEDIA_STREAM_REQUEST_H_
 #define CONTENT_PUBLIC_COMMON_MEDIA_STREAM_REQUEST_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/callback_forward.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/common/content_export.h"
+#include "media/audio/audio_parameters.h"

[ajm, 2013/12/10 06:37:16]

This trips a presubmit check:
"You added one or more #includes that violate checkdeps rules."

I suppose I'll have to copy over the definition of PlatformEffects? I'll do that
tomorrow.

[tommi (sloooow) - chröme, 2013/12/11 12:14:36]

Yes unfortunately.  That's why we're not using AudioParameters for sample rate,
channel layout etc here.  It would be good if we didn't have to have this here
though since I'm not convinced these details need to be a part of the public
content interface... hmm... no action on that in this cl though.

 #include "url/gurl.h"
 
 namespace content {
 
 // Types of media streams.
 enum MediaStreamType {
   MEDIA_NO_SERVICE = 0,
 
   // A device provided by the operating system (e.g., webcam input).
   MEDIA_DEVICE_AUDIO_CAPTURE,
@@ skipping 77 matching lines @@
   std::string name;
 
   // Contains properties that match directly with those with the same name
   // in media::AudioParameters.
   struct AudioDeviceParameters {
     AudioDeviceParameters()
         : sample_rate(), channel_layout(), frames_per_buffer() {
     }
 
     AudioDeviceParameters(int sample_rate, int channel_layout,
-                          int frames_per_buffer)
+        int frames_per_buffer)
         : sample_rate(sample_rate),
           channel_layout(channel_layout),
           frames_per_buffer(frames_per_buffer) {
     }
 
     // Preferred sample rate in samples per second for the device.
     int sample_rate;
 
     // Preferred channel configuration for the device.
     // TODO(henrika): ideally, we would like to use media::ChannelLayout here
     // but including media/base/channel_layout.h violates checkdeps rules.
     int channel_layout;
 
     // Preferred number of frames per buffer for the device.  This is filled
     // in on the browser side and can be used by the renderer to match the
     // expected browser side settings and avoid unnecessary buffering.
     // See media::AudioParameters for more.
     int frames_per_buffer;
+
+    // See media::AudioParameters.
+    media::AudioParameters::PlatformEffects effects;
   };
 
   // These below two member variables are valid only when the type of device is
   // audio (i.e. IsAudioMediaType returns true).
 
   // Contains the device properties of the capture device.
   AudioDeviceParameters input;
 
   // If the capture device has an associated output device (e.g. headphones),
   // this will contain the properties for the output device.  If no such device
@@ skipping 80 matching lines @@
 };
 
 // Callback used return results of media access requests.
 typedef base::Callback<void(
     const MediaStreamDevices& devices,
     scoped_ptr<MediaStreamUI> ui)> MediaResponseCallback;
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_MEDIA_STREAM_REQUEST_H_