content/common/permission_service.mojom - Issue 990303002: Implement PermissionService::GetNextPermissionChange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/permission_service.mojom

Issue 990303002: Implement PermissionService::GetNextPermissionChange. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_impl

Patch Set: review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/permissions/permission_manager_thread_proxy.h ('K') | « content/child/permissions/permission_manager_thread_proxy.cc ('k') | content/content_child.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/permission_service.mojom

diff --git a/content/common/permission_service.mojom b/content/common/permission_service.mojom

index 9dd952dbe44f50cb51fc7da655583380c45a8c32..16d4866355cc354779ad887a2b4eefc2b0136498 100644

--- a/content/common/permission_service.mojom

+++ b/content/common/permission_service.mojom

@@ -8,8 +8,9 @@ import "content/public/common/permission_status.mojom";

enum PermissionName {

GEOLOCATION,

- MIDI_SYSEX,

NOTIFICATIONS,

+ PUSH_NOTIFICATIONS,

+ MIDI_SYSEX,

PROTECTED_MEDIA_IDENTIFIER,

};

@@ -23,4 +24,13 @@ interface PermissionService {

=> (PermissionStatus status);

RevokePermission(PermissionName permission, string origin)

=> (PermissionStatus status);

+ // Runs the callback next time there is a permission status change for the

+ // given { permission, origin }. Callers of this method will have to call it

+ // again if they want to keep listening to the changes. To prevent race

+ // conditions, the caller must pass the last known value.

+ GetNextPermissionChange(PermissionName permission,

+ string origin,

+ PermissionStatus last_known_status)

+ => (PermissionStatus status);

};