chrome/browser/content_settings/permission_context.h - Issue 990303002: Implement PermissionService::GetNextPermissionChange.

Side by Side Diff: chrome/browser/content_settings/permission_context.h

Issue 990303002: Implement PermissionService::GetNextPermissionChange. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_impl

Patch Set: cosmetic changes Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/content_settings/permission_context.cc » ('j') | chrome/browser/content_settings/permission_observer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_H_

	6 #define CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_H_

	7

	8 #include "components/content_settings/core/common/content_settings_types.h"

	9

	10 class PermissionContextBase;

	11 class Profile;

	12

	13 namespace PermissionContext {
	Bernhard Bauer 2015/03/11 14:06:18 Namespaces should be lowercase_with_underscores. O Namespaces should be lowercase_with_underscores. Or you could make this a class with only static methods... mlamouri (slow - plz ping) 2015/03/18 16:24:40 Done. Show quoted text On 2015/03/11 at 14:06:18, Bernhard Bauer wrote: > Namespaces should be lowercase_with_underscores. Or you could make this a class with only static methods... Done.
	14

	15 // Helper method returning the PermissionContextBase object associated with the

	16 // given ContentSettingsType.

	17 PermissionContextBase* Get(Profile* profile,
	mlamouri (slow - plz ping) 2015/03/11 11:38:17 This could be renamed PermissionContextFactory::Cr This could be renamed PermissionContextFactory::Create() to match what it is actually abstracting. Also, I would gladly move that one directory up if it's a problem to have chrome/browser/content_settings/ to be aware of the different PermissionContextBase factories. Bernhard Bauer 2015/03/11 14:06:18 I prefer Get() over Create(), as the method doesn' Show quoted text On 2015/03/11 11:38:17, Mounir Lamouri wrote: > This could be renamed PermissionContextFactory::Create() to match what it is > actually abstracting. I prefer Get() over Create(), as the method doesn't unconditionally create a permission context. And neither PermissionContext nor PermissionContextFactory are actually classses, so both would be in the wrong naming style. Show quoted text > Also, I would gladly move that one directory up if it's a problem to have > chrome/browser/content_settings/ to be aware of the different > PermissionContextBase factories. Meh, as long as there is no conceptual layering violation, I'm fine to keep both in the same directory until content settings and permissions get separated out more explicitly. mlamouri (slow - plz ping) 2015/03/18 16:24:40 Sounds good. Show quoted text On 2015/03/11 at 14:06:18, Bernhard Bauer wrote: > On 2015/03/11 11:38:17, Mounir Lamouri wrote: > > This could be renamed PermissionContextFactory::Create() to match what it is > > actually abstracting. > > I prefer Get() over Create(), as the method doesn't unconditionally create a permission context. And neither PermissionContext nor PermissionContextFactory are actually classses, so both would be in the wrong naming style. > > > Also, I would gladly move that one directory up if it's a problem to have > > chrome/browser/content_settings/ to be aware of the different > > PermissionContextBase factories. > > Meh, as long as there is no conceptual layering violation, I'm fine to keep both in the same directory until content settings and permissions get separated out more explicitly. Sounds good.
	18 ContentSettingsType content_settings_type);

	19

	20 } // namespace PermissionContext

	21

	22 #endif // CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_H_

OLD	NEW