Push API: Prevent DCHECK when clear permissions after clear SW DB

chrome/browser/push_messaging/push_messaging_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 #include <string>
 
 #include "base/barrier_closure.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/browsing_data/browsing_data_helper.h"
+#include "chrome/browser/browsing_data/browsing_data_remover.h"
+#include "chrome/browser/browsing_data/browsing_data_remover_test_util.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/notifications/notification_test_util.h"
 #include "chrome/browser/notifications/platform_notification_service_impl.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/push_messaging/push_messaging_application_id.h"
 #include "chrome/browser/push_messaging/push_messaging_constants.h"
 #include "chrome/browser/push_messaging/push_messaging_service_factory.h"
 #include "chrome/browser/push_messaging/push_messaging_service_impl.h"
 #include "chrome/browser/services/gcm/fake_gcm_profile_service.h"
 #include "chrome/browser/services/gcm/gcm_profile_service_factory.h"
@@ skipping 993 matching lines @@
   // if the rules it used to have have been reset.
   // The Push service should not unsubcribe |origin| because at no point it was
   // left without permission to use Push.
 
   ASSERT_TRUE(RunScript("hasPermission()", &script_result));
   EXPECT_EQ("permission status - granted", script_result);
 
   ASSERT_TRUE(RunScript("hasRegistration()", &script_result));
   EXPECT_EQ("true - registered", script_result);
 }
+
+// Checks that automatically unsubscribing due to a revoked permission is
+// handled well if the sender ID needed to unregister was already deleted.
+IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
+                       ResetPushPermissionAfterClearingSiteData) {
+  std::string script_result;
+
+  TryToRegisterSuccessfully("1-0" /* expected_push_registration_id */);
+
+  PushMessagingApplicationId app_id = GetServiceWorkerAppId(0LL);
+  EXPECT_EQ(app_id.app_id_guid(), gcm_service()->last_registered_app_id());
+  PushMessagingApplicationId stored_app_id = PushMessagingApplicationId::Get(
+      browser()->profile(), app_id.app_id_guid());
+  EXPECT_TRUE(stored_app_id.IsValid());
+
+  // Simulate a user clearing site data (including Service Workers, crucially).
+  BrowsingDataRemover* remover =
+      BrowsingDataRemover::CreateForUnboundedRange(browser()->profile());
+  BrowsingDataRemoverCompletionObserver observer(remover);
+  remover->Remove(BrowsingDataRemover::REMOVE_SITE_DATA,
+                  BrowsingDataHelper::UNPROTECTED_WEB);
+  observer.BlockUntilCompletion();
+  // BrowsingDataRemover deletes itself.
+
+  base::RunLoop run_loop;
+  push_service()->SetContentSettingChangedCallbackForTesting(
+      run_loop.QuitClosure());
+
+  // This shouldn't (asynchronously) cause a DCHECK.
+  // TODO(johnme): Get this test running on Android, since that's where the
+  // DCHECK occurred (crbug.com/464328).

[mlamouri (slow - plz ping), 2015/03/13 16:25:49]

Are you going to fix that bug with that CL?

Also, please https://crbug.com/...

[johnme, 2015/03/13 17:21:12]

Yes, this CL fixes that bug. I've changed the comment to:

"
// TODO(johnme): Get this test running on Android, which has a different
// codepath due to sender_id being required for unregistering there."

+  browser()->profile()->GetHostContentSettingsMap()->
+      ClearSettingsForOneType(CONTENT_SETTINGS_TYPE_PUSH_MESSAGING);
+
+  run_loop.Run();
+
+  // app_id should no longer be stored in prefs
+  PushMessagingApplicationId stored_app_id2 = PushMessagingApplicationId::Get(
+      browser()->profile(), app_id.app_id_guid());
+  EXPECT_FALSE(stored_app_id2.IsValid());
+}