Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1891)

Unified Diff: build/standalone.gypi

Issue 990253002: Fix full rebuilding after clang rolls. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index 1aedbcd595904e3c5a5cef1f1e5cc28a4ea23197..95ffb998d9d727b8fb3f0da5dbfd7659a13ff1d7 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -193,6 +193,16 @@
# Xcode insists on this empty entry.
},
},
+ 'conditions':[
+ ['(clang==1 or host_clang==1) and OS!="win"', {
+ # This is here so that all files get recompiled after a clang roll and
+ # when turning clang on or off.
+ # (defines are passed via the command line, and build systems rebuild
+ # things when their commandline changes). Nothing should ever read this
+ # define.
+ 'defines': ['CR_CLANG_REVISION=<!(<(DEPTH)/tools/clang/scripts/update.sh --print-revision)'],
+ }],
+ ],
'target_conditions': [
['v8_code == 0', {
'defines!': [
@@ -558,14 +568,6 @@
['CC', '../<(clang_dir)/bin/clang-cl'],
],
}],
- ['(clang==1 or host_clang==1) and OS!="win"', {
- # This is here so that all files get recompiled after a clang roll and
- # when turning clang on or off.
- # (defines are passed via the command line, and build systems rebuild
- # things when their commandline changes). Nothing should ever read this
- # define.
- 'defines': ['CR_CLANG_REVISION=<!(<(DEPTH)/tools/clang/scripts/update.sh --print-revision)'],
- }],
# TODO(yyanagisawa): supports GENERATOR==make
# make generator doesn't support CC_wrapper without CC
# in make_global_settings yet.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698