Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 990223002: <extensionoptions>: Remove dead code (Closed)

Created:
5 years, 9 months ago by Fady Samuel
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<extensionoptions>: Remove dead code autosize is no longer used in <extensionoptions> and it adds a lot of complexity. I eventually want <extensionview> and <extensionoptions> to merge to reduce maintenance overhead, especially on the <webview>/GuestView team. This dead code makes it harder to reach that objective. BUG=442033 Committed: https://crrev.com/a15eb3b6f6585ed649442f1e8de9ef7426071ab1 Cr-Commit-Position: refs/heads/master@{#319692}

Patch Set 1 #

Patch Set 2 : Fixed broken test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -213 lines) Patch
M chrome/renderer/resources/extensions/extension_options.js View 4 chunks +2 lines, -153 lines 0 comments Download
M chrome/renderer/resources/extensions/extension_options_events.js View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/test/data/extensions/api_test/extension_options/embed_self/test.js View 1 1 chunk +0 lines, -26 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.h View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M extensions/common/api/extension_options_internal.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Fady Samuel
Before I create a bug for this, do you know if there's an existing bug?
5 years, 9 months ago (2015-03-09 14:57:04 UTC) #2
not at google - send to devlin
I'd put it under 442033. Also I'm guessing there is some test that relies on ...
5 years, 9 months ago (2015-03-09 16:37:47 UTC) #3
Fady Samuel
On 2015/03/09 16:37:47, kalman wrote: > I'd put it under 442033. Also I'm guessing there ...
5 years, 9 months ago (2015-03-09 16:51:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990223002/20001
5 years, 9 months ago (2015-03-09 16:51:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 18:25:13 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 18:26:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a15eb3b6f6585ed649442f1e8de9ef7426071ab1
Cr-Commit-Position: refs/heads/master@{#319692}

Powered by Google App Engine
This is Rietveld 408576698