Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 990203002: Make VerifyMarking work in the presence of grey objects (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make VerifyMarking work in the presence of grey objects R=hpayer@chromium.org LOG=n BUG=none Committed: https://crrev.com/34c43513a34db5b01b12d220f0c9a9d870a470da Cr-Commit-Position: refs/heads/master@{#27079}

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/heap/mark-compact.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-09 13:43:17 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/990203002/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/990203002/diff/1/src/heap/mark-compact.cc#newcode105 src/heap/mark-compact.cc:105: // Take into account that a marked objected is ...
5 years, 9 months ago (2015-03-09 13:49:25 UTC) #2
jochen (gone - plz use gerrit)
what about this?
5 years, 9 months ago (2015-03-09 13:52:25 UTC) #3
Hannes Payer (out of office)
lgtm
5 years, 9 months ago (2015-03-09 14:43:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990203002/20001
5 years, 9 months ago (2015-03-09 14:44:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 15:01:38 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 15:01:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34c43513a34db5b01b12d220f0c9a9d870a470da
Cr-Commit-Position: refs/heads/master@{#27079}

Powered by Google App Engine
This is Rietveld 408576698