Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Issue 990183004: Revert of [Android] Fix a flicker in stopping Chrome (Closed)

Created:
5 years, 9 months ago by jdduke (slow)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Fix a flicker in stopping Chrome (patchset #11 id:200001 of https://codereview.chromium.org/843883002/) Reason for revert: Caused regression with lockscreen battery consumption. Original issue's description: > [Android] Fix a flicker in stopping Chrome > > Currently, we draw a blank frame as we release resources in onStop(). > This can be prevented if we hide the tab when the window gets hidden instead of > on activity stop. > > BUG=434401 > > Committed: https://crrev.com/e4b1990c9d49fd9734940fa863513ad43b82c6e7 > Cr-Commit-Position: refs/heads/master@{#311809} TBR=tedchoc@chromium.org,dtrainor@chromium.org,yusufo@chromium.org,aelias@chromium.org,sievers@chromium.org,changwan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=434401 Committed: https://crrev.com/e278dc74a72b863889e17ea110516fb028fe5d47 Cr-Commit-Position: refs/heads/master@{#319713}

Patch Set 1 #

Patch Set 2 : REbase #

Messages

Total messages: 8 (2 generated)
jdduke (slow)
Created Revert of [Android] Fix a flicker in stopping Chrome
5 years, 9 months ago (2015-03-09 19:33:37 UTC) #1
no sievers
lgtm
5 years, 9 months ago (2015-03-09 19:38:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990183004/170001
5 years, 9 months ago (2015-03-09 19:44:07 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:170001)
5 years, 9 months ago (2015-03-09 19:45:31 UTC) #6
jdduke (slow)
On 2015/03/09 19:45:31, I haz the power (commit-bot) wrote: > Committed patchset #2 (id:170001) I ...
5 years, 9 months ago (2015-03-09 19:46:09 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 19:46:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e278dc74a72b863889e17ea110516fb028fe5d47
Cr-Commit-Position: refs/heads/master@{#319713}

Powered by Google App Engine
This is Rietveld 408576698