Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 990173002: Recorded slots in store buffer are never in free space. Remove migration consistency check. (Closed)

Created:
5 years, 9 months ago by Hannes Payer (out of office)
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Recorded slots in store buffer are never in free space. Remove migration consistency check. After establishing the invariant that the store buffer always has valid slots after marking, the store buffer integrity check is not needed anymore. BUG=454157 LOG=n Committed: https://crrev.com/ded6ffbb2ab636031ae1cd00f002886325426cec Cr-Commit-Position: refs/heads/master@{#27073}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M src/heap/heap.cc View 1 2 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Hannes Payer (out of office)
5 years, 9 months ago (2015-03-09 12:15:06 UTC) #2
Jarin
lgtm. It's great to see this hack go...
5 years, 9 months ago (2015-03-09 12:38:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990173002/20001
5 years, 9 months ago (2015-03-09 12:51:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990173002/40001
5 years, 9 months ago (2015-03-09 12:57:18 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-09 13:33:16 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 13:33:26 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ded6ffbb2ab636031ae1cd00f002886325426cec
Cr-Commit-Position: refs/heads/master@{#27073}

Powered by Google App Engine
This is Rietveld 408576698