Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 990153003: Telemetry: Keep original exception's stacktrace in inspector_backend. (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Keep original exception's stacktrace in inspector_backend. InspectorBackend converts exceptions generated by the websocket library into Telemetry exceptions. In the process, it was losing the original stacktrace. BUG=NONE Committed: https://crrev.com/72bf8d182a23c36614fd049c276d6a34e991cc02 Cr-Commit-Position: refs/heads/master@{#319821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
erikchen
dtu: Please review.
5 years, 9 months ago (2015-03-10 00:16:44 UTC) #2
dtu
Great! I knew there was some place where we needed this fix. Glad you found ...
5 years, 9 months ago (2015-03-10 00:23:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990153003/1
5 years, 9 months ago (2015-03-10 00:26:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 02:14:16 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 02:14:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72bf8d182a23c36614fd049c276d6a34e991cc02
Cr-Commit-Position: refs/heads/master@{#319821}

Powered by Google App Engine
This is Rietveld 408576698