Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 990093002: Fix GYP cross-compilation issue w/ build_utf8_validator_tables. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GYP cross-compilation issue w/ build_utf8_validator_tables. I think, when explicitly declaring a dependency on a target (like gn_all does on build_utf8_validator_tables), if the target is unconditionally only built in the host toolset, the dependency needs to also say that; my initial version of the dependency did not do that, leading gyp_chromium to fail in obscure ways. R=thakis@chromium.org BUG=465198 Committed: https://crrev.com/3b02cf778cdb3066ed3cbb9b2d70413a1577033e Cr-Commit-Position: refs/heads/master@{#319666}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M build/gn_migration.gypi View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
5 years, 9 months ago (2015-03-09 05:19:53 UTC) #1
Nico
lgtm, this is conceptually correct. (I didn't verify that these two targets indeed say 'toolsets': ...
5 years, 9 months ago (2015-03-09 05:41:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990093002/1
5 years, 9 months ago (2015-03-09 16:35:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 17:20:13 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 17:21:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b02cf778cdb3066ed3cbb9b2d70413a1577033e
Cr-Commit-Position: refs/heads/master@{#319666}

Powered by Google App Engine
This is Rietveld 408576698