Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 990063004: Async DNS: Disable on Linux until we parse nsswitch.conf (Closed)

Created:
4 years, 1 month ago by Deprecated (see juliatuttle)
Modified:
4 years, 1 month ago
Reviewers:
cbentzel, *davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Async DNS: Disable on Linux until we parse nsswitch.conf Right now, we don't examine nsswitch.conf, but we assume it has a standard (hosts: files dns) configuration for hostname resolution. We should check that that's true before activating the internal resolver, and fall back to the OS resolver if it's not. In the meantime, however, just disable Async DNS on Linux so it doesn't break for users with nonstandard configurations. BUG=117655 Committed: https://crrev.com/1a2a2738522cb00347f277e8e7d725a4e46ed053 Cr-Commit-Position: refs/heads/master@{#320160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/net/async_dns_field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Deprecated (see juliatuttle)
PTAL, davidben.
4 years, 1 month ago (2015-03-10 22:23:44 UTC) #3
davidben
lgtm
4 years, 1 month ago (2015-03-11 00:54:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990063004/1
4 years, 1 month ago (2015-03-11 20:06:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/48993)
4 years, 1 month ago (2015-03-11 20:34:48 UTC) #10
cbentzel
LGTM
4 years, 1 month ago (2015-03-11 21:25:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990063004/1
4 years, 1 month ago (2015-03-11 21:55:06 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2015-03-11 22:06:20 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2015-03-11 22:07:13 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a2a2738522cb00347f277e8e7d725a4e46ed053
Cr-Commit-Position: refs/heads/master@{#320160}

Powered by Google App Engine
This is Rietveld 408576698