x11: Use scoped_ptr<> for X11 objects where it makes sense.

ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h"
 
 #include <X11/extensions/shape.h>
 #include <X11/extensions/XInput2.h>
 #include <X11/Xatom.h>
 #include <X11/Xregion.h>
@@ skipping 789 matching lines @@
       // none. The comment in desktop_native_widget_aura.cc suggests that this
       // is rare.
       NOTIMPLEMENTED();
   }
 }
 
 void DesktopWindowTreeHostX11::FlashFrame(bool flash_frame) {
   if (urgency_hint_set_ == flash_frame)
     return;
 
-  XWMHints* hints = XGetWMHints(xdisplay_, xwindow_);
+  gfx::XScopedPtr<XWMHints> hints(XGetWMHints(xdisplay_, xwindow_));
   if (!hints) {
     // The window hasn't had its hints set yet.
-    hints = XAllocWMHints();
+    hints.reset(XAllocWMHints());
   }
 
   if (flash_frame)
     hints->flags |= XUrgencyHint;
   else
     hints->flags &= ~XUrgencyHint;
 
-  XSetWMHints(xdisplay_, xwindow_, hints);
-  XFree(hints);
+  XSetWMHints(xdisplay_, xwindow_, hints.get());
 
   urgency_hint_set_ = flash_frame;
 }
 
 void DesktopWindowTreeHostX11::OnRootViewLayout() {
   UpdateMinAndMaxSize();
 }
 
 void DesktopWindowTreeHostX11::OnNativeWidgetFocus() {
   native_widget_delegate_->AsWidget()->GetInputMethod()->OnFocus();
@@ skipping 695 matching lines @@
   SkAutoLockPixels locker(bitmap);
 
   for (int y = 0; y < height; ++y)
     for (int x = 0; x < width; ++x)
       data->push_back(bitmap.getColor(x, y));
 }
 
 Visual* DesktopWindowTreeHostX11::GetARGBVisual() {
   XVisualInfo visual_template;
   visual_template.screen = 0;
-  Visual* to_return = NULL;
 
   int visuals_len;
-  XVisualInfo* visual_list = XGetVisualInfo(xdisplay_,
-                                            VisualScreenMask,
-                                            &visual_template, &visuals_len);
+  gfx::XScopedPtr<XVisualInfo[]> visual_list(XGetVisualInfo(
+      xdisplay_, VisualScreenMask, &visual_template, &visuals_len));
   for (int i = 0; i < visuals_len; ++i) {
     // Why support only 8888 ARGB? Because it's all that GTK+ supports. In
     // gdkvisual-x11.cc, they look for this specific visual and use it for all
     // their alpha channel using needs.
     //
     // TODO(erg): While the following does find a valid visual, some GL drivers
     // don't believe that this has an alpha channel. According to marcheu@,
     // this should work on open source driver though. (It doesn't work with
     // NVidia's binaries currently.) http://crbug.com/369209
-    if (visual_list[i].depth == 32 &&
-        visual_list[i].visual->red_mask == 0xff0000 &&
-        visual_list[i].visual->green_mask == 0x00ff00 &&
-        visual_list[i].visual->blue_mask == 0x0000ff) {
-      to_return = visual_list[i].visual;
-      break;
+    const XVisualInfo& info = visual_list[i];
+    if (info.depth == 32 && info.visual->red_mask == 0xff0000 &&
+        info.visual->green_mask == 0x00ff00 &&
+        info.visual->blue_mask == 0x0000ff) {
+      return info.visual;
     }
   }
 
-  if (visual_list)
-    XFree(visual_list);
-
-  return to_return;
+  return nullptr;
 }
 
 std::list<XID>& DesktopWindowTreeHostX11::open_windows() {
   if (!open_windows_)
     open_windows_ = new std::list<XID>();
   return *open_windows_;
 }
 
 void DesktopWindowTreeHostX11::MapWindow(ui::WindowShowState show_state) {
   if (show_state != ui::SHOW_STATE_DEFAULT &&
@@ skipping 410 matching lines @@
   if (linux_ui) {
     ui::NativeTheme* native_theme = linux_ui->GetNativeTheme(window);
     if (native_theme)
       return native_theme;
   }
 
   return ui::NativeTheme::instance();
 }
 
 }  // namespace views