Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 989963002: Trigger use of viewportAndroid.css through new setting. (Closed)

Created:
5 years, 9 months ago by rune
Modified:
5 years, 9 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trigger use of viewportAndroid.css through new setting. A setting is used instead of an OS(ANDROID) ifdef in blink in [1]. This CL enables that setting for Android on the chromium side along with other Android specific settings. [1] https://codereview.chromium.org/979033003/ Committed: https://crrev.com/d1677fd03abc26d747174dafb7124a42d505ae2e Cr-Commit-Position: refs/heads/master@{#320251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rune
5 years, 9 months ago (2015-03-08 00:45:21 UTC) #2
aelias_OOO_until_Jul13
lgtm, adding sievers@ for OWNERS
5 years, 9 months ago (2015-03-10 17:14:02 UTC) #4
no sievers
lgtm
5 years, 9 months ago (2015-03-10 18:26:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989963002/1
5 years, 9 months ago (2015-03-12 08:15:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 09:02:02 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 09:02:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1677fd03abc26d747174dafb7124a42d505ae2e
Cr-Commit-Position: refs/heads/master@{#320251}

Powered by Google App Engine
This is Rietveld 408576698