Remove internal uses of deprecated MakeWeak.

Remove internal uses of deprecated MakeWeak.

[Sven Panne, 2013-12-02 14:27:50]

The changes are quite mechanical (introduce a pair where necessary) and might
not win a beauty contest... :-}

[Michael Starzinger, 2013-12-02 15:34:09]

LGTM. Only nits.

https://codereview.chromium.org/98993002/diff/40001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/98993002/diff/40001/src/d8.cc#newcode51
src/d8.cc:51: #include <utility>
nit: Can we move this up to the other system includes (i.e. line 42) and
alpha-sort that block?

https://codereview.chromium.org/98993002/diff/40001/src/d8.cc#newcode1107
src/d8.cc:1107: -data.GetValue()->ByteLength());
I guess there will be some casting problem between size_t and intptr_t here on
some compiler. But we will see.

https://codereview.chromium.org/98993002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/98993002/diff/40001/test/cctest/test-api.cc#n...
test/cctest/test-api.cc:32: #include <utility>
nit: Can we alpha-sort the system includes block?

[Sven Panne, 2013-12-02 17:30:52]

https://codereview.chromium.org/98993002/diff/40001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/98993002/diff/40001/src/d8.cc#newcode51
src/d8.cc:51: #include <utility>
On 2013/12/02 15:34:10, Michael Starzinger wrote:
> nit: Can we move this up to the other system includes (i.e. line 42) and
> alpha-sort that block?

Nope, the presubmit check insists on this order: C headers, then C++ header,
then own headers. :-P

https://codereview.chromium.org/98993002/diff/40001/src/d8.cc#newcode1107
src/d8.cc:1107: -data.GetValue()->ByteLength());
On 2013/12/02 15:34:10, Michael Starzinger wrote:
> I guess there will be some casting problem between size_t and intptr_t here on
> some compiler. But we will see.

To be honest, I would prefer to see a compiler warning (if any) compared to a
silent wrong conversion. In general, our use of integral types makes me cry,
almost every API is broken, so it's hard to get the call sites right if you have
2 wrong types for impedance matching. :-P

https://codereview.chromium.org/98993002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/98993002/diff/40001/test/cctest/test-api.cc#n...
test/cctest/test-api.cc:32: #include <utility>
On 2013/12/02 15:34:10, Michael Starzinger wrote:
> nit: Can we alpha-sort the system includes block?

Done.

[Sven Panne, 2013-12-03 15:37:59]

Superseded by https://codereview.chromium.org/101523002/ which is slightly more
complex than necessary...