Issue 989923002: Revert of Do not fire didStartLoading and didStopLoading events twice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 989923002: Revert of Do not fire didStartLoading and didStopLoading events twice. (Closed)

Created:
5 years, 9 months ago by f(malita)

Modified:
5 years, 9 months ago

Reviewers:
clamy, Nate Chapin, Fabrice (no longer in Chrome)

CC:
blink-reviews, tyoshino+watch_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, rwlbuis, jbroman

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of Do not fire didStartLoading and didStopLoading events twice. (patchset #2 id:20001 of https://codereview.chromium.org/984983002/) Reason for revert: WebContentsImplBrowserTest.ClearNonVisiblePendingOnFail timeouts, blocking rolls: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/40719/steps/content_browsertests%20%28with%20patch%29/logs/stdio Original issue's description: > Do not fire didStartLoading and didStopLoading events twice. > > This issue was found by extra DCHECK on the Chromium side, ensuring these events > are never fired more than once. > > BUG=464675, 429399 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191464 TBR=japhet@chromium.org,clamy@chromium.org,fdegans@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464675, 429399 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191486

Patch Set 1 #

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	Source/core/dom/Document.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/core/loader/FrameLoader.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

f(malita)

Created Revert of Do not fire didStartLoading and didStopLoading events twice.

5 years, 9 months ago (2015-03-07 21:55:35 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989923002/1

5 years, 9 months ago (2015-03-07 21:56:11 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-07 21:56:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191486

Expand Messages | Collapse Messages