Issue 989873002: Revert of For consistency, use our homebrew zlib everywhere possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 989873002: Revert of For consistency, use our homebrew zlib everywhere possible. (Closed)

Created:
5 years, 9 months ago by mtklein

Modified:
5 years, 9 months ago

Reviewers:
scroggo, mtklein_C

CC:
reviews_skia.org, hal.canary

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of For consistency, use our homebrew zlib everywhere possible. (patchset #6 id:100001 of https://codereview.chromium.org/971673005/) Reason for revert: Reverting in case this is the cause of the non-Windows failures. Original issue's description: > For consistency, use our homebrew zlib everywhere possible. > > This switches when we build our own zlib from "just Windows" to "everyone, but > not Android framework of course". > > I tested this by building DM for my Mac and for an Android bot config. > It took minor tweaks to the GYP to get ARM builds working. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/5a8f2257b0b0f954fb74f65e7ea3ada772ed9240 TBR=scroggo@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/82966b5eeda13a899fb6f632f7d38e61c146c4e1

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -33 lines)			Patch
	M	gyp/zlib.gyp	View		3 chunks	+29 lines, -33 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of For consistency, use our homebrew zlib everywhere possible.

5 years, 9 months ago (2015-03-07 15:47:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989873002/1

5 years, 9 months ago (2015-03-07 15:47:44 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-07 15:47:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/82966b5eeda13a899fb6f632f7d38e61c146c4e1