Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4147)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 989843002: [Extensions] Make chrome://extensions use developerPrivate for inspect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index c1cd9673cb913fbf7f6e4d82dd0fa3b86ee95239..80fb6d1b34165ea197db641249d609c643f4dfd3 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -22,11 +22,9 @@
#include "chrome/browser/background/background_contents.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
-#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
#include "chrome/browser/extensions/component_loader.h"
#include "chrome/browser/extensions/crx_installer.h"
-#include "chrome/browser/extensions/devtools_util.h"
#include "chrome/browser/extensions/error_console/error_console.h"
#include "chrome/browser/extensions/extension_action_manager.h"
#include "chrome/browser/extensions/extension_error_reporter.h"
@@ -731,9 +729,6 @@ void ExtensionSettingsHandler::RegisterMessages() {
web_ui()->RegisterMessageCallback("extensionSettingsToggleDeveloperMode",
base::Bind(&ExtensionSettingsHandler::HandleToggleDeveloperMode,
AsWeakPtr()));
- web_ui()->RegisterMessageCallback("extensionSettingsInspect",
- base::Bind(&ExtensionSettingsHandler::HandleInspectMessage,
- AsWeakPtr()));
web_ui()->RegisterMessageCallback("extensionSettingsLaunch",
base::Bind(&ExtensionSettingsHandler::HandleLaunchMessage,
AsWeakPtr()));
@@ -994,45 +989,6 @@ void ExtensionSettingsHandler::HandleToggleDeveloperMode(
developer_mode_on);
}
-void ExtensionSettingsHandler::HandleInspectMessage(
- const base::ListValue* args) {
- std::string extension_id;
- std::string render_process_id_str;
- std::string render_view_id_str;
- int render_process_id;
- int render_view_id;
- bool incognito;
- CHECK_EQ(4U, args->GetSize());
- CHECK(args->GetString(0, &extension_id));
- CHECK(args->GetString(1, &render_process_id_str));
- CHECK(args->GetString(2, &render_view_id_str));
- CHECK(args->GetBoolean(3, &incognito));
- CHECK(base::StringToInt(render_process_id_str, &render_process_id));
- CHECK(base::StringToInt(render_view_id_str, &render_view_id));
-
- if (render_process_id == -1) {
- // This message is for a lazy background page. Start the page if necessary.
- Profile* profile = Profile::FromWebUI(web_ui());
- const Extension* extension =
- ExtensionRegistry::Get(profile)->enabled_extensions().GetByID(
- extension_id);
- DCHECK(extension);
- if (incognito)
- profile = profile->GetOffTheRecordProfile();
- devtools_util::InspectBackgroundPage(extension, profile);
- return;
- }
-
- RenderViewHost* host = RenderViewHost::FromID(render_process_id,
- render_view_id);
- if (!host || !WebContents::FromRenderViewHost(host)) {
- // This can happen if the host has gone away since the page was displayed.
- return;
- }
-
- DevToolsWindow::OpenDevToolsWindow(WebContents::FromRenderViewHost(host));
-}
-
void ExtensionSettingsHandler::HandleLaunchMessage(
const base::ListValue* args) {
CHECK_EQ(1U, args->GetSize());

Powered by Google App Engine
This is Rietveld 408576698