chrome/browser/extensions/api/developer_private/developer_private_api.h - Issue 989843002: [Extensions] Make chrome://extensions use developerPrivate for inspect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.h

Issue 989843002: [Extensions] Make chrome://extensions use developerPrivate for inspect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | third_party/closure_compiler/externs/developer_private.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api.h

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.h b/chrome/browser/extensions/api/developer_private/developer_private_api.h

index 60edc0ce3ed328e7cf14d5221df7ff957d5c319c..b54a33abb2a628d8f7cae67f5bc869b26349aa36 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.h

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.h

@@ -228,7 +228,7 @@ class DeveloperPrivateGetItemsInfoFunction

bool generated_background_page);

};

-class DeveloperPrivateInspectFunction : public ChromeSyncExtensionFunction {

+class DeveloperPrivateInspectFunction : public UIThreadExtensionFunction {

public:

DECLARE_EXTENSION_FUNCTION("developerPrivate.inspect",

DEVELOPERPRIVATE_INSPECT)

@@ -237,7 +237,7 @@ class DeveloperPrivateInspectFunction : public ChromeSyncExtensionFunction {

~DeveloperPrivateInspectFunction() override;

// ExtensionFunction:

- bool RunSync() override;

+ ResponseAction Run() override;

};

class DeveloperPrivateAllowFileAccessFunction