chrome/browser/resources/extensions/extension_list.js - Issue 989843002: [Extensions] Make chrome://extensions use developerPrivate for inspect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 989843002: [Extensions] Make chrome://extensions use developerPrivate for inspect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ben's Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extension_list.js

diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js

index 16b11322a5281b1d57869ed58818efc5323d9662..03387a42444bc92abf35df99cc846d6516f06e8c 100644

--- a/chrome/browser/resources/extensions/extension_list.js

+++ b/chrome/browser/resources/extensions/extension_list.js

@@ -730,13 +730,12 @@ cr.define('extensions', function() {

' ' + loadTimeData.getString('viewInactive') : '');

link.textContent = label;

link.clickHandler = function(e) {

- // TODO(estade): remove conversion to string?

- chrome.send('extensionSettingsInspect', [

- String(extension.id),

- String(view.renderProcessId),

- String(view.renderViewId),

- view.incognito

- ]);

+ chrome.developerPrivate.inspect({

+ extension_id: extension.id,

+ render_process_id: view.renderProcessId,

+ render_view_id: view.renderViewId,

+ incognito: view.incognito

Dan Beam 2015/03/09 20:26:25 nit: 2\s less indent

Devlin 2015/03/09 22:10:27 Done.

+ });

};

link.addEventListener('click', link.clickHandler);